Implement paratime picker #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
06722de
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://20b491fb.oasis-explorer.pages.dev |
| Branch Preview URL: | https://ml-paratime-picker-component.oasis-explorer.pages.dev |
lubej
force-pushed
the
ml/paratime-picker-component
branch
5 times, most recently
from
77a6bd2
to
d102751
Compare
buberdds
reviewed
Apr 5, 2023
lubej
force-pushed
the
ml/paratime-picker-component
branch
2 times, most recently
from
1b6aea2
to
06737d7
Compare
lukaw3d
reviewed
Apr 6, 2023
lubej
force-pushed
the
ml/paratime-picker-component
branch
3 times, most recently
from
250a588
to
ab3da1b
Compare
lukaw3d
reviewed
Apr 7, 2023
lukaw3d
reviewed
Apr 7, 2023
| </Link> | ||
| <Button | ||
| variant="text" | ||
| onClick={onLayerModalOpen} |
There was a problem hiding this comment.
I liked going back to dashboard with this title 😢
There was a problem hiding this comment.
Issue here is that on mobile the button is used to trigger the modal. I can wrap it with Link on desktop, if that makes sense? Or do we want to keep it for completeness.
lukaw3d
reviewed
Apr 7, 2023
lukaw3d
reviewed
Apr 7, 2023
lukaw3d
approved these changes
Apr 13, 2023
lubej
force-pushed
the
ml/paratime-picker-component
branch
from
3a21f96
to
06722de
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add paratime picker modal
https://www.loom.com/share/8404c5bb406644409370eb9e6cf03f5e