ETH/Oasis address toggle on Txn details view #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubej
force-pushed
the
ml/address-toggle-on-txn-details-view
branch
3 times, most recently
from
99f9283
to
d9ac648
Compare
lubej
force-pushed
the
ml/address-toggle-on-txn-details-view
branch
from
d9ac648
to
81410ba
Compare
lubej
force-pushed
the
ml/address-toggle-on-txn-details-view
branch
from
77826cd
to
a6eed92
Compare
lubej
force-pushed
the
ml/address-toggle-on-txn-details-view
branch
from
ad2d2ec
to
3540cb7
Compare
Deployed to Cloudflare Pages
|
lubej
force-pushed
the
ml/address-toggle-on-txn-details-view
branch
2 times, most recently
from
6464477
to
2764480
Compare
lubej
force-pushed
the
ml/address-toggle-on-txn-details-view
branch
from
2764480
to
bf885f6
Compare
lubej
force-pushed
the
ml/address-toggle-on-txn-details-view
branch
3 times, most recently
from
2aaa10e
to
7ce4287
Compare
lukaw3d
reviewed
Jun 6, 2023
Comment on lines
93
to
96
| ? isMobile | ||
| ? COLORS.white | ||
| : COLORS.brandExtraDark | ||
| : COLORS.grayMediumDark, |
There was a problem hiding this comment.
I don't like that implementation details of SubPageCard are leaking into AddressSwitch. Can we structure things better?
cc @csillag do you know if there's an obvious solution with themes? e.g. marking mobile SubPageCard header as dark theme?
lukaw3d
reviewed
Jun 6, 2023
lukaw3d
requested changes
Jun 6, 2023
lubej
force-pushed
the
ml/address-toggle-on-txn-details-view
branch
from
7ce4287
to
e1038f7
Compare
lubej
force-pushed
the
ml/address-toggle-on-txn-details-view
branch
from
8aa3fc7
to
36c1dc0
Compare
lubej
force-pushed
the
ml/address-toggle-on-txn-details-view
branch
from
36c1dc0
to
248dc52
Compare
lukaw3d
approved these changes
Jun 9, 2023
lubej
force-pushed
the
ml/address-toggle-on-txn-details-view
branch
from
248dc52
to
2733140
Compare
lubej
force-pushed
the
ml/address-toggle-on-txn-details-view
branch
from
2733140
to
c45d8bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution
Add ETH/Oasis address toggle on transaction details view
Links