-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup Cloudflare deploys via Github Action #289
Conversation
Deploying with Cloudflare Pages
|
7803bf9
to
0b725da
Compare
Deployed to Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it would work well 👍 needs a token
b738c1e
to
e99bf93
Compare
@tjanez API Token description updated. We only need Cloudflare Pages Edit permission. Tested on fork buberdds#30
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added the secrets, so let's check if this works.
2204c2f
to
62f8165
Compare
Thanks, secrets look Ok. We can remove Github App integration before merge. https://github.com/oasisprotocol/explorer/settings/installations |
Something is wrong: Old bot: New workflow: |
hmm how this is even possible that footer |
CI logs say: Is github by default doing "merged results pipelines" (gitlab term)? :O |
I guess this is fine 🤷 |
that might work - even on push event the other alternative is https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#pull_request_target but looks like it carries extra risk |
I will merge and disable until switch |
<td><a href="${{ steps.cloudflare.outputs.url }}">${{ steps.cloudflare.outputs.url }}</a></td> | ||
</tr> | ||
</table> | ||
message-failure: | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should have message-cancelled
too
see: #289 (comment)
from a cancelled run: https://github.com/oasisprotocol/explorer/actions/runs/4752003232/jobs/8441821763
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed by #314
Requires:
CLOUDFRONT_API_TOKEN
andCLOUDFRONT_ACCOUNT_ID
secrets on repo levelhttps://github.com/oasisprotocol/explorer/settings/secrets/actions
Setup:
API Token
(https://github.com/cloudflare/pages-action#generate-an-api-token)https://dash.cloudflare.com/profile/api-tokens -> Create ->
At the bottom under Custom Token -> Get started ->
Provide Token name ->
Under Permissions, select Account, Cloudflare Pages and Edit
Select Continue to summary > Create Token.
Account ID
Dashboard home -> Left side navigation -> Workers -> Overview -> Account ID is listed on the right side
Suspend Github CloudFlare github app https://github.com/oasisprotocol/explorer/settings/installations
Sample output:
default: buberdds#20
skipped for Renovate bot: buberdds#22