Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create homepage network selector component #394

Merged
merged 1 commit into from May 18, 2023
Merged

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented May 17, 2023

Network switcher used in home page. PR covers only UI. Logic for switching links in graph will be covered in next PR.

@github-actions
Copy link

github-actions bot commented May 17, 2023

Deployed to Cloudflare Pages

Latest commit: d16772779e02743407bfe6d4df214d8ff94cdd78
Status:✅ Deploy successful!
Preview URL: https://a6c947cf.oasis-explorer.pages.dev

@buberdds buberdds force-pushed the mz/homepage-network branch 11 times, most recently from f8c6b89 to 91d20f7 Compare May 17, 2023 13:39
src/app/pages/HomePage/Graph/NetoworkSelector/index.tsx Outdated Show resolved Hide resolved
Comment on lines 81 to 82
<StyledButton
onClick={() => setNetwork(option as Network)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToggleButton seems like a nicer component to use here

src/app/pages/HomePage/Graph/ParaTimeSelector/index.tsx Outdated Show resolved Hide resolved
src/app/pages/HomePage/Graph/NetoworkSelector/index.tsx Outdated Show resolved Hide resolved
@buberdds buberdds merged commit d9b9bdd into master May 18, 2023
4 checks passed
@buberdds buberdds deleted the mz/homepage-network branch May 18, 2023 11:03
@csillag
Copy link
Contributor

csillag commented May 19, 2023

Network switcher used in home page. PR covers only UI. Logic for switching links in graph will be covered in next PR.

The logic is now handled by #402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants