Tune the behavior of the Paratime Picker - Clicky version #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/tuning-picker
branch
3 times, most recently
from
1ab5efa
to
af259f4
Compare
|
After discussing this with @donouwens , we came to the conclusion that this is not (necessarily) what we want to do here. |
csillag
force-pushed
the
csillag/tuning-picker
branch
2 times, most recently
from
df5239f
to
633ad7f
Compare
csillag
changed the title
csillag
force-pushed
the
csillag/tuning-picker
branch
from
633ad7f
to
fc5c60b
Compare
|
Updated as discussed |
csillag
force-pushed
the
csillag/tuning-picker
branch
2 times, most recently
from
1966143
to
fa3ead9
Compare
lukaw3d
reviewed
Jun 8, 2023
lukaw3d
approved these changes
Jun 8, 2023
| setHoveredLayer(layer) | ||
| }} | ||
| onClick={() => setSelectedLayer(layer)} | ||
| onMouseLeave={() => { | ||
| setHoveredLayer() |
There was a problem hiding this comment.
We can later simplify to css :hover
csillag
force-pushed
the
csillag/tuning-picker
branch
from
fa3ead9
to
45b4555
Compare
csillag
force-pushed
the
csillag/tuning-picker
branch
from
45b4555
to
aa6a96b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale coming at the next chance to talk.
See #479 for a no-click alternative.