Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust global search #478

Merged
merged 4 commits into from Jun 8, 2023
Merged

Adjust global search #478

merged 4 commits into from Jun 8, 2023

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Jun 8, 2023

Depends on #476

  • Only show MainNet results by default; the rest only upon request.
  • Group results by network and not scopes.
  • Inside network sections, sort results by paratime.

@csillag csillag requested a review from lukaw3d June 8, 2023 00:30
@github-actions
Copy link

github-actions bot commented Jun 8, 2023

Deployed to Cloudflare Pages

Latest commit: c0873686bdc559598f8d346053e0577b3b9598c9
Status:✅ Deploy successful!
Preview URL: https://90aa93ea.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/adjust-global-search branch 5 times, most recently from 30667b6 to 4bf884a Compare June 8, 2023 03:16
@csillag csillag self-assigned this Jun 8, 2023
@csillag csillag force-pushed the csillag/adjust-global-search branch 3 times, most recently from 92e2784 to 05560ee Compare June 8, 2023 13:51
@csillag csillag force-pushed the csillag/adjust-global-search branch 2 times, most recently from e1efb12 to 7c155a3 Compare June 8, 2023 16:53
@csillag csillag force-pushed the csillag/adjust-global-search branch from 7c155a3 to 2eec20f Compare June 8, 2023 16:56
Global Search:
- Only show MainNet results by default; the rest only upon request.
- Group results by network and not scopes.
- Inside network sections, sort results by paratime.

Scoped search:
- Filter out other paratimes earlier in the process, and simplify data flow
- Before redirecting, also consider other results

Generel:
- Remove some unnecessary variables in conditions
  Just write the calculations inside the expressions,
  it makes it easier to understand.
@csillag csillag force-pushed the csillag/adjust-global-search branch from 2eec20f to c087368 Compare June 8, 2023 16:57
@csillag csillag merged commit ccc5f69 into master Jun 8, 2023
6 checks passed
@csillag csillag deleted the csillag/adjust-global-search branch June 8, 2023 17:00
@csillag csillag mentioned this pull request Jun 8, 2023
@lukaw3d lukaw3d added the p0 High priority label Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p0 High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants