Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Move banners into sticky header" #486

Merged
merged 1 commit into from Jun 12, 2023
Merged

Conversation

lukaw3d
Copy link
Member

@lukaw3d lukaw3d commented Jun 9, 2023

This reverts commit 56fc8cc.

@donouwens: Actually, I would prefer the warning banners to not remain within the viewport, to reduce the screen estate the take up

@lukaw3d lukaw3d requested review from csillag and donouwens June 9, 2023 15:38
@github-actions
Copy link

github-actions bot commented Jun 9, 2023

Deployed to Cloudflare Pages

Latest commit: 6a4157c3d80e35f971312a0954bfc6ff77242ce1
Status:✅ Deploy successful!
Preview URL: https://4c2033f9.oasis-explorer.pages.dev

@lukaw3d
Copy link
Member Author

lukaw3d commented Jun 9, 2023

Before After
before after

Copy link
Contributor

@csillag csillag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. LGTM

@buberdds buberdds merged commit 3b91bbf into master Jun 12, 2023
6 checks passed
@buberdds buberdds deleted the lw/unstick-banners branch June 12, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants