Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paratime Picker design feedback #500

Merged
merged 3 commits into from Jun 13, 2023
Merged

Paratime Picker design feedback #500

merged 3 commits into from Jun 13, 2023

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Jun 12, 2023 •
edited

@github-actions
Copy link

github-actions bot commented Jun 12, 2023 •
edited

Deployed to Cloudflare Pages

Latest commit: 7d92e87017c09f781ebb6a921119fb84c3bc027a
Status:✅ Deploy successful!
Preview URL: https://69973704.oasis-explorer.pages.dev

@csillag
Copy link
Contributor

csillag commented Jun 12, 2023

Please note that we also have #482 , waiting for review. Maybe it would make sense to finish that first?

@buberdds
Copy link
Contributor Author

Validated by Don, ready for a review. I don't think it has to wait as PRs target different problems.

@buberdds buberdds requested review from lubej and csillag June 13, 2023 06:14
csillag
csillag approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@csillag csillag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. LGTM.

@buberdds buberdds merged commit 82a0633 into master Jun 13, 2023
6 checks passed
@buberdds buberdds deleted the mz/pickerFix branch June 13, 2023 07:59
@csillag csillag mentioned this pull request Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csillag csillag csillag approved these changes

@lubej lubej Awaiting requested review from lubej lubej is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@buberdds @csillag