Indicate encrypted transactions in TX lists #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
force-pushed
the
csillag/indicate-encryption
branch
2 times, most recently
from
3aa9803
to
911931c
Compare
|
Visuals validated by @donouwens |
buberdds
reviewed
Jun 13, 2023
buberdds
reviewed
Jun 13, 2023
csillag
force-pushed
the
csillag/indicate-encryption
branch
from
911931c
to
a12e292
Compare
buberdds
reviewed
Jun 13, 2023
buberdds
approved these changes
Jun 13, 2023
csillag
force-pushed
the
csillag/indicate-encryption
branch
from
a12e292
to
b032346
Compare
buberdds
reviewed
Jun 13, 2023
| @@ -57,3 +57,7 @@ export function getEthAccountAddress(preimage: AddressPreimage | undefined): str | |||
| // We need to convert from base64 to hex, add the prefix, and convert to checksum address | |||
| return toChecksumAddress(`0x${Buffer.from(preimage.address_data, 'base64').toString('hex')}`) | |||
| } | |||
|
|
|||
| export function uniq<T>(input: T[] | undefined): T[] { | |||
| return input === undefined ? [] : [...new Set(input)] | |||
There was a problem hiding this comment.
not sure we need this function, but Ok. [...new Set(undefined)] will return an empty array anyway
lukaw3d
reviewed
Jun 19, 2023
Comment on lines
+72
to
+74
| ...(canHaveEncryption | ||
| ? [{ content: (<LockIcon htmlColor={COLORS.grayMedium} />) as unknown as string }] | ||
| : []), // The table does support widgets in the column headers, but the TS definition is unaware of that. |
There was a problem hiding this comment.
Table does not support it too well
explorer/src/app/components/Table/index.tsx
Line 108 in a77aa3a
There was a problem hiding this comment.
Yes, that could be improved. (By generating the key using the index, or something similar.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per https://app.clickup.com/t/861mx1bew and https://app.clickup.com/t/861mx1kwu
For testing, look for block 411186 on Sapphire testnet, or the account 0x6fA03516728d4a483578D63ea124C4Ec4A00e2bB