Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First steps towards displaying contract info #544

Merged
merged 2 commits into from Jun 20, 2023

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Jun 15, 2023

This depends on #542.

First steps towards supporting contracts:

  • When displaying a contract, say so in the title
  • Show link to TX that created the contract

For testing, search for address 0x301879c8677e050f0f7104fe6a3059806Abb41C6

For reviewing, I suggest going commit by commit.

@github-actions
Copy link

github-actions bot commented Jun 15, 2023

Deployed to Cloudflare Pages

Latest commit: 17305eb8533d42e22395a03f70043445a27a66e2
Status:✅ Deploy successful!
Preview URL: https://6f689276.oasis-explorer.pages.dev

@csillag csillag requested review from lukaw3d and buberdds June 16, 2023 07:12
@csillag csillag force-pushed the csillag/display-contracts-basics branch 5 times, most recently from ba3cb31 to d0a6b06 Compare June 19, 2023 08:36
src/locales/en/translation.json Outdated Show resolved Hide resolved
src/app/pages/AddressDetailsPage/index.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@buberdds buberdds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For renaming part let's wait other folks input too.

@csillag csillag force-pushed the csillag/display-contracts-basics branch 3 times, most recently from 7cf1b2e to 2062505 Compare June 19, 2023 13:03
@csillag csillag enabled auto-merge June 19, 2023 13:25
@csillag csillag force-pushed the csillag/display-contracts-basics branch 3 times, most recently from 3063e7d to d46d6cc Compare June 19, 2023 14:09
@csillag csillag force-pushed the csillag/display-contracts-basics branch from d46d6cc to 15dcbe6 Compare June 20, 2023 17:17
@csillag
Copy link
Contributor Author

csillag commented Jun 20, 2023

For renaming part let's wait other folks input too.

After discussion, I have undone the renaming.

@csillag csillag requested a review from buberdds June 20, 2023 17:18
- When displaying a contract, say so in the title
- Show link to TX that created the contract
@csillag csillag force-pushed the csillag/display-contracts-basics branch from 15dcbe6 to 17305eb Compare June 20, 2023 17:20
@csillag csillag merged commit c2566a8 into master Jun 20, 2023
7 checks passed
@csillag csillag deleted the csillag/display-contracts-basics branch June 20, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants