Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tokens page and dashboard component #546

Merged
merged 4 commits into from Jun 19, 2023
Merged

Conversation

csillag
Copy link
Contributor

@csillag csillag commented Jun 16, 2023

This has:

  • New component for tokens on the Dashboard page
  • Tokens overview page. (desktop, mobile horizontal, mobile vertical view)
  • Currently, all links simply point to the (contract) address page, to be enhanced later.

Please note that Emerald has more tokens and sapphire, so I have re-enabled Emerald (on Mainnet) for testing.
I will drop that commit just before merging.

@github-actions
Copy link

github-actions bot commented Jun 16, 2023

Deployed to Cloudflare Pages

Latest commit: 91a2c217f28d80ea3fe0c084f6fe21abe71e773c
Status:✅ Deploy successful!
Preview URL: https://24143315.oasis-explorer.pages.dev

@csillag csillag force-pushed the csillag/tokens-page branch 2 times, most recently from a9ea6c7 to 5e723c7 Compare June 16, 2023 02:54
@csillag csillag changed the title Add Tokens page [W.I.P] Add Tokens page Jun 16, 2023
@csillag csillag force-pushed the csillag/tokens-page branch 3 times, most recently from 38a833c to ece4d04 Compare June 16, 2023 09:12
@csillag csillag changed the title [W.I.P] Add Tokens page Add Tokens page and dashboard component Jun 16, 2023
@csillag csillag marked this pull request as ready for review June 16, 2023 09:15
@csillag csillag force-pushed the csillag/tokens-page branch 2 times, most recently from 41dd979 to a806803 Compare June 16, 2023 09:29
@csillag csillag requested review from buberdds and lukaw3d June 16, 2023 09:38
@csillag csillag force-pushed the csillag/tokens-page branch 2 times, most recently from 4ba4aa3 to 24e1401 Compare June 16, 2023 12:57
@donouwens
Copy link
Collaborator

Looks all good to me. Thanks @csillag

@csillag csillag force-pushed the csillag/tokens-page branch 3 times, most recently from 5321870 to 35f4942 Compare June 19, 2023 10:02
src/app/components/Tokens/TokenList.tsx Outdated Show resolved Hide resolved
src/app/components/Tokens/TokenList.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@buberdds buberdds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice start, but what's a plan for tokens feature? Should it be hidden for now so internal releases are "stable"/fully functional or we don't care about internal releases and we are aiming for public launch only?

@csillag
Copy link
Contributor Author

csillag commented Jun 19, 2023

but what's a plan for tokens feature? Should it be hidden for now so internal releases are "stable"/fully functional or we don't care about internal releases and we are aiming for public launch only?

I think the indexer has already merged the PRs for extended support (including getting data about the individual tokens etc), so I think we will be flash out the support soon enough. I don't know about the plan for the releases and milestone.

@csillag csillag merged commit a77aa3a into master Jun 19, 2023
7 checks passed
@csillag csillag deleted the csillag/tokens-page branch June 19, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants