Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParaTime picker internal feedback #582

Merged
merged 12 commits into from Jun 23, 2023
Merged

ParaTime picker internal feedback #582

merged 12 commits into from Jun 23, 2023

Conversation

buberdds
Copy link
Contributor

@buberdds buberdds commented Jun 22, 2023

Waiting for Don's feedback

@github-actions
Copy link

github-actions bot commented Jun 22, 2023

Deployed to Cloudflare Pages

Latest commit: 6c5e27586151cb61c247fcd3490129957e0cedce
Status:✅ Deploy successful!
Preview URL: https://39bb568c.oasis-explorer.pages.dev

@buberdds buberdds force-pushed the mz/picker branch 8 times, most recently from e156d52 to 5eb27c4 Compare June 23, 2023 08:22
@buberdds buberdds force-pushed the mz/picker branch 3 times, most recently from 74948e5 to 07b9556 Compare June 23, 2023 08:50
@buberdds buberdds marked this pull request as ready for review June 23, 2023 09:03
@buberdds buberdds requested review from lubej and lukaw3d and removed request for lubej and lukaw3d June 23, 2023 09:03
@@ -203,12 +203,13 @@ const ParaTimePickerContent: FC<ParaTimePickerContentProps> = ({ onClose, onConf

<Button
onClick={() => onConfirm(selectedNetwork!, selectedLayer!)}
disabled={selectedNetwork === network && selectedLayer === layer}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

Comment on lines -516 to +508
height: `calc(100vh - var(--app-header-height) - var(--app-banners-height))`,
top: `calc(var(--app-header-height) + var(--app-banners-height))`,
height: '100vh',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buberdds buberdds merged commit 4817898 into master Jun 23, 2023
7 checks passed
@buberdds buberdds deleted the mz/picker branch June 23, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants