Display account token transfers #624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployed to Cloudflare Pages
|
csillag
changed the title
csillag
force-pushed
the
csillag/display-account-token-transfers
branch
7 times, most recently
from
7b31e2c
to
6d58e95
Compare
csillag
requested review from
lukaw3d and
buberdds
and removed request for
lukaw3d
lukaw3d
reviewed
Jun 29, 2023
csillag
force-pushed
the
csillag/display-account-token-transfers
branch
4 times, most recently
from
5273e48
to
680f5f5
Compare
lukaw3d
approved these changes
Jun 30, 2023
csillag
force-pushed
the
csillag/display-account-token-transfers
branch
4 times, most recently
from
db08bd4
to
5398e1d
Compare
(For ticker and decimals to be used when displaying token transfers in a list.)
csillag
force-pushed
the
csillag/display-account-token-transfers
branch
from
5398e1d
to
36f4f8d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built on top of #616, so only the last few comments are relevant to this task.Display token transfers related to an account.
Design:
Can be tested (for example) with
0x643c8A8120eFB675E82C5C58d8D473f5aDd0B5e6.Unfortunately, our data requirements are not completely clear at this point, so only a part of the visual is implemented. However, this is probably all we can do before the launch, so it makes sense to review this now.