Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph network dropdown #667

Merged
merged 1 commit into from Jul 7, 2023
Merged

Graph network dropdown #667

merged 1 commit into from Jul 7, 2023

Conversation

lubej
Copy link
Collaborator

@lubej lubej commented Jul 5, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Jul 5, 2023

Deployed to Cloudflare Pages

Latest commit: 6fbeff02671fab966cc20cda3f507150d493c305
Status:✅ Deploy successful!
Preview URL: https://ed5a49b9.oasis-explorer.pages.dev

@lubej lubej force-pushed the ml/graph-network-picker branch 3 times, most recently from 7b0e16f to 95c6f09 Compare July 6, 2023 14:11
@lubej lubej changed the title Graph network picker Graph network dropdown Jul 6, 2023
@lubej lubej marked this pull request as ready for review July 6, 2023 14:16
@lubej lubej requested review from buberdds, lukaw3d and csillag and removed request for buberdds and lukaw3d July 6, 2023 14:17
@csillag
Copy link
Contributor

csillag commented Jul 6, 2023

Can we have a little bit a description about what is supposed to happen her? (Task in words, link to visuals, etc.) Thanks.

@lukaw3d
Copy link
Member

lukaw3d commented Jul 6, 2023

This has a bit of an issue with keyboard accessibility

Before After
tab-before tab

@lubej lubej enabled auto-merge July 7, 2023 08:09
@lubej lubej merged commit 59189d8 into master Jul 7, 2023
7 checks passed
@lubej lubej deleted the ml/graph-network-picker branch July 7, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants