Tweak token snapshot cards #704
Conversation
Deployed to Cloudflare Pages
|
| @@ -30,7 +30,7 @@ export const TokenTypeCard: FC = () => { | |||
| color: COLORS.brandDark, | |||
| }} | |||
| > | |||
| {token?.type ? getTokenTypeName(t, token.type) : '-'} | |||
| {token?.type ? getTokenTypeStrictName(t, token.type) : '-'} | |||
There was a problem hiding this comment.
What is the reason for this change?
Don specifically asked me earlier to use the full form (like "Token (ERC-20)")
There was a problem hiding this comment.
Yep, waiting for Don's feedback here. It looks pretty bad currently.
There was a problem hiding this comment.
Did he accept this earlier ?
There was a problem hiding this comment.
At what zoom level and screen size do you get that?
I get this:
There was a problem hiding this comment.
But even if there is a problem with the formatting of the card, shouldn't we just fix the formatting issue? Why change the content?
There was a problem hiding this comment.
Did he accept this earlier ?
Yes, when discussing #685
There was a problem hiding this comment.
Did he accept this earlier ?
(We were also running slack chat as a side-channel, so yes, I think he really did.)
There was a problem hiding this comment.
I can see it now I will open a new PR. Typography is wrong in Tokens snapshot. When it's fixed we should be fine with old content.
| notation: 'compact', | ||
| } satisfies Intl.NumberFormatOptions, | ||
| }, | ||
| })} |
There was a problem hiding this comment.
So this format is different than what we are trying to use in #703, although it's the very same data. I think we should use the same formatting everywhere...
There was a problem hiding this comment.
yeah I agree it should be the same. Will talk with Don tomorrow.
No description provided.