KVStore: Factor out fetching of a typed value

oasisprotocol · May 5, 2023 · f8d29c7 · f8d29c7
1 parent 2be609e
commit f8d29c7
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/storage/oasis/nodeapi/file/common.go b/storage/oasis/nodeapi/file/common.go
@@ -73,10 +73,7 @@ func GetFromCacheOrCall[Value any](cache KVStore, volatile bool, key CacheKey, v
 
 	// If the value is cached, return it.
 	isCached, err := cache.Has(key)
-	if err != nil {
-		return nil, err
-	}
-	if isCached {
+	if err == nil && isCached {
 		raw, err2 := cache.Get(key)
 		if err2 != nil {
 			cache.logger.Warn(fmt.Sprintf("failed to fetch key %s from cache: %v", key.Pretty(), err2))