Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/runtime/transactions: Populate the timestamp #304

Merged
merged 1 commit into from
Feb 3, 2023
Merged

/runtime/transactions: Populate the timestamp #304

merged 1 commit into from
Feb 3, 2023

Conversation

mitjat
Copy link
Collaborator

@mitjat mitjat commented Feb 2, 2023

After this PR:

  • analyzer saves block timestamp into the tx DB table (this is denormailzed, but I opted for this rather than a JOIN every time we're serving txs)
  • API reads it from the DB, presents it

Resolves https://app.clickup.com/t/861maqp0p

@mitjat mitjat force-pushed the mitjat/runtime-tx-timestamp branch from 96d7466 to 715db86 Compare February 2, 2023 22:50
@mitjat mitjat enabled auto-merge February 2, 2023 22:50
Andrew7234
Andrew7234 approved these changes Feb 3, 2023
View reviewed changes
Copy link
Collaborator

@Andrew7234 Andrew7234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; might want to update the comment at https://github.com/oasisprotocol/oasis-indexer/blob/main/api/spec/v1.yaml#L1884 too

@mitjat
Copy link
Collaborator Author

mitjat commented Feb 3, 2023

Looks good; might want to update the comment at main/api/spec/v1.yaml#L1884 too

I'm actually still not confident about what the answer is there :/

@mitjat mitjat force-pushed the mitjat/runtime-tx-timestamp branch from 715db86 to 5dbb9fc Compare February 3, 2023 09:34
@mitjat mitjat merged commit 6d3c08e into main Feb 3, 2023
@mitjat mitjat deleted the mitjat/runtime-tx-timestamp branch February 3, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Andrew7234 Andrew7234 Andrew7234 approved these changes

@aefhm aefhm Awaiting requested review from aefhm

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mitjat @Andrew7234