Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC-721 support #447

Merged
merged 14 commits into from Jun 29, 2023
Merged

ERC-721 support #447

merged 14 commits into from Jun 29, 2023

Conversation

pro-wh
Copy link
Collaborator

@pro-wh pro-wh commented Jun 14, 2023 •
edited

functionality:

  • token scanner can detect ERC-721 using ERC-165 supportsInterface
  • block scanner can detect ERC-721 events and schedule token scanning
  • schedules 'mutable' parts rescan (i.e. total supply) when tokens are minted
  • registers transaction related accounts when seeing events

not included:

  • approvals tracking (similar to that not being supported for ERC-20)
  • tracking ownership of tokens
  • holders count

tested on recent blocks on emerald, where a BlockchainCuties transfer had occurred

@pro-wh pro-wh force-pushed the pro-wh/feature/erc721 branch 3 times, most recently from 78663ee to ed38538 Compare June 20, 2023 23:32
@pro-wh
Copy link
Collaborator Author

pro-wh commented Jun 20, 2023

Error: if ok && supportsMetadata has complex nested blocks (complexity: 6) (nestif)

😠

mitjat
mitjat reviewed Jun 21, 2023
View reviewed changes
Copy link
Collaborator

@mitjat mitjat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, and close to victory!

analyzer/runtime/evm/client.go Show resolved Hide resolved
analyzer/runtime/evm/client.go Outdated Show resolved Hide resolved
analyzer/runtime/evm/client.go Outdated Show resolved Hide resolved
analyzer/runtime/evm/client.go Outdated Show resolved Hide resolved
analyzer/runtime/evm/erc165.go Show resolved Hide resolved
analyzer/runtime/evm/erc165.go Show resolved Hide resolved
analyzer/runtime/evm/erc165.go Outdated Show resolved Hide resolved
@pro-wh pro-wh force-pushed the pro-wh/feature/erc721 branch 2 times, most recently from aead573 to a2842d1 Compare June 22, 2023 22:30
@pro-wh pro-wh marked this pull request as ready for review June 22, 2023 22:31
pro-wh
pro-wh commented Jun 22, 2023
View reviewed changes
analyzer/runtime/extract.go Outdated Show resolved Hide resolved
@pro-wh pro-wh force-pushed the pro-wh/feature/erc721 branch 3 times, most recently from 9d8e88b to 2a1a196 Compare June 23, 2023 21:59
@pro-wh pro-wh mentioned this pull request Jun 23, 2023
Merged
mitjat
mitjat approved these changes Jun 27, 2023
View reviewed changes
Copy link
Collaborator

@mitjat mitjat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

analyzer/runtime/evm/erc165.go Show resolved Hide resolved
analyzer/runtime/extract.go Outdated Show resolved Hide resolved
analyzer/runtime/extract.go Show resolved Hide resolved
analyzer/runtime/extract.go Show resolved Hide resolved
storage/client/queries/queries.go Show resolved Hide resolved
@pro-wh pro-wh merged commit 4e770e4 into main Jun 29, 2023
6 checks passed
@pro-wh pro-wh deleted the pro-wh/feature/erc721 branch June 29, 2023 20:24
@csillag csillag mentioned this pull request Jul 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitjat mitjat mitjat approved these changes

@aefhm aefhm Awaiting requested review from aefhm

@Andrew7234 Andrew7234 Awaiting requested review from Andrew7234 Andrew7234 is a code owner

@ptrus ptrus Awaiting requested review from ptrus ptrus is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pro-wh @mitjat