Remove RuntimeSourceStorage abstraction #449
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
approved these changes
Jun 15, 2023
|
Thank you for the review. I accidentally merged PRs out of order, so this change went in as part of #448 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
RuntimeSourceStorageinterface in favor of directly using the underlyingnodeapi.RuntimeApiLite.As a TODO in the code said, this wrapper had no utility any more.
My motivation in removing it was that I needed to introduce one more method to the runtime API, and it sucks to have one more layer of boilerplate to pipe the results through.
This PR does not remove the similar
ConsensusSourceStorage. It is similarly useless, but it does restructure the data fromConsensusApiLitea little instead of just passing it through, which makes it more work to rip out.