e2e_regression: Fix expected output after #452 #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitjat
force-pushed
the
mitjat/e2e-fix-after-452
branch
from
497951e
to
b7f4224
Compare
mitjat
force-pushed
the
mitjat/e2e-fix-after-452
branch
from
b7f4224
to
ddd5339
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized after #452 went in that its e2e regression test was broken, and that we do not block PRs on that.
This PR fixes the test; the change in expected output is expected :)
I separately changed the repo settings so we now require e2e tests to pass before merging the PR.
The PR also updates run.sh so that diffs show more cleany.