Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

status: Expose datetime of most recent block #462

Merged
merged 1 commit into from Jun 27, 2023

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jun 25, 2023

Resloves https://app.clickup.com/t/866af85d2

Testing (locally):

curl "localhost:8008/v1/"
{"latest_block":8049056,"latest_block_time":"2022-04-11T13:12:48+02:00","latest_update":"2023-06-25T09:20:13+02:00"}


curl "localhost:8008/v1/emerald/status"
{"active_nodes":0,"latest_block":1004425,"latest_block_time":"2022-04-11T17:04:34+02:00","latest_update":"2023-06-25T09:18:49+02:00"}

@ptrus ptrus force-pushed the ptrus/feature/latest-block-timestamp branch from a8fd71a to df67795 Compare June 25, 2023 07:34
Copy link
Contributor

@aefhm aefhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy weekend LGTM, but defer to the other gents.

Copy link
Collaborator

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg here too

Copy link
Collaborator

@mitjat mitjat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM also!
Bummer that we "have to" make a separate query (instead of using a JOIN) because of the consensus/runtime distinction.

@mitjat
Copy link
Collaborator

mitjat commented Jun 27, 2023

Since the change is pretty small and there are no reviewer suggestions, I'll go against convention and merge this PR in. This way, it can make it into the release I'm hoping to cut in the next few hours.

@mitjat mitjat merged commit e9a24f1 into main Jun 27, 2023
6 checks passed
@mitjat mitjat deleted the ptrus/feature/latest-block-timestamp branch June 27, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants