Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: move some wipe logic out to functions #465

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Conversation

pro-wh
Copy link
Collaborator

@pro-wh pro-wh commented Jun 27, 2023

run the deferred rows.Close() earlier

Copy link
Collaborator

@mitjat mitjat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, tasty. Thanks.

Linter is complaining about a err value being lost somewhere, but it looks like the line number is missing? 😕

storage/postgres/client.go Outdated Show resolved Hide resolved
@pro-wh pro-wh force-pushed the pro-wh/feature/wipe branch 2 times, most recently from 5f5bf36 to a665fa3 Compare June 29, 2023 20:54
@pro-wh
Copy link
Collaborator Author

pro-wh commented Jun 30, 2023

ah yeah nice catch lint

@pro-wh pro-wh merged commit f484425 into main Jun 30, 2023
6 checks passed
@pro-wh pro-wh deleted the pro-wh/feature/wipe branch June 30, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants