Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Andrew7234/evmtokens api #493

Merged
merged 2 commits into from Jul 31, 2023
Merged

Andrew7234/evmtokens api #493

merged 2 commits into from Jul 31, 2023

Conversation

Andrew7234
Copy link
Collaborator

@Andrew7234 Andrew7234 commented Jul 20, 2023 •
edited

From slack:

When listing tokens via the /:runtime/evm_tokens, we need as part of the EvmToken object:
  - data about the underlying token contract:
    - eth address
    - verification status (we only need a boolean, not the whole data structure)```

ptrus
ptrus reviewed Jul 20, 2023
View reviewed changes
api/spec/v1.yaml Outdated Show resolved Hide resolved
@csillag
Copy link
Contributor

csillag commented Jul 20, 2023

👍🏻

@csillag csillag mentioned this pull request Jul 20, 2023
Merged
@csillag
Copy link
Contributor

csillag commented Jul 20, 2023

This will be used by oasisprotocol/explorer#760

@Andrew7234 Andrew7234 force-pushed the andrew7234/evmtokens-api branch 3 times, most recently from 41763ac to 8a1d53a Compare July 21, 2023 00:59
mitjat
mitjat approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@mitjat mitjat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

storage/client/queries/queries.go Show resolved Hide resolved
storage/client/queries/queries.go Outdated Show resolved Hide resolved
api/spec/v1.yaml Outdated
@@ -2534,6 +2534,13 @@ components:
description: |
The number of addresses that have a nonzero balance of this token.
example: 123
verified:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preferably is_verified, so it's clear to readers that this is a bool (and not e.g. the date when this was verified, or the detailed results of verification).
This is in the vein of

nexus/api/spec/v1.yaml

Line 1149 in 774ab49

is_total_count_clipped:
and

nexus/api/spec/v1.yaml

Line 2306 in 774ab49

is_likely_native_token_transfer:

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed; changed! @csillag heads up that the api will change slightly here

Base automatically changed from andrew7234/erc-event-info to main July 31, 2023 14:53
@Andrew7234
[openapi] EvmToken: make eth_addr required and add verified field
71009ed 
[api] update evmtokens endpoints

address comments

address comments

nit
@Andrew7234 Andrew7234 merged commit 82c10f7 into main Jul 31, 2023
6 checks passed
@Andrew7234 Andrew7234 deleted the andrew7234/evmtokens-api branch July 31, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitjat mitjat mitjat approved these changes

@ptrus ptrus ptrus approved these changes

@aefhm aefhm Awaiting requested review from aefhm

@pro-wh pro-wh Awaiting requested review from pro-wh pro-wh is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Andrew7234 @csillag @mitjat @ptrus