Andrew7234/evm token transfers #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andrew7234
requested review from
aefhm,
mitjat,
pro-wh and
ptrus
as code owners
mitjat
approved these changes
Aug 22, 2023
analyzer/runtime/runtime.go
Outdated
Comment on lines
307
to
309
| // Note that total_supply is optional for ERC721 contracts. | ||
| // If the evm_tokens analyzer is able to fetch the total supply from the node, | ||
| // it will supersede this. |
There was a problem hiding this comment.
Suggested change
| // Note that total_supply is optional for ERC721 contracts. | |
| // If the evm_tokens analyzer is able to fetch the total supply from the node, | |
| // it will supersede this. | |
| // Note that total_supply is optional for ERC721 contracts. | |
| // If the evm_tokens analyzer is able to fetch the total supply from the node, | |
| // it will supersede this, but implementing totalSupply() is optional for ERC721 contracts, | |
| // so we have to maintain this dead-reckoned fallback. |
Wording nit, just to make it clearer what the implications are of having an optional totalSupply()
Andrew7234
force-pushed
the
andrew7234/evm-token-transfers
branch
from
91efa67
to
6e59c56
Compare
[analyzer] dead-reckon numTransfers [api] update with evmtokens.numTransfers linter address comment rename migration
Andrew7234
force-pushed
the
andrew7234/evm-token-transfers
branch
from
6e59c56
to
d753ce1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clickup.com/t/8692hqtf5
Adds support for dead-reckoning
evmToken.NumTransferswithout using triggers.The accounting in this is almost identical to how we track
evmToken.TotalSupply, in that we maintain two dead-reckoned sums inanalysis.evmTokensandchain.evmTokensfor possible and confirmed evm tokens, respectively. Once the evmTokens analyzer downloads a token, it copies the value fromanalysistochain.