Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus roothash messages #599

Merged
merged 15 commits into from
Apr 10, 2024
Merged

consensus roothash messages #599

merged 15 commits into from
Apr 10, 2024

Conversation

pro-wh
Copy link
Collaborator

@pro-wh pro-wh commented Jan 5, 2024

roothash messages are small structures that a runtime can send to communicate with the consensus layer. they are agreed upon for each runtime block. we'll see the messages themselves in the proposal for that block, i.e. in the first executor commit for the round. the consensus layer processes these messages when the block gets finalized, which produces a result for each message. in cobalt and below, the roothash consensus app emits an event for each message. in damask and up, the results are stored on chain, and you use a roothash "get last round results" query to look up the results.

in this feature, we add a roothash_messages table with tracked runtimes' messages and results. either of the message or result may be absent, as they can be disseminated in different consensus blocks.

@pro-wh pro-wh force-pushed the pro-wh/feature/roothash branch 2 times, most recently from 7f8dd09 to d92613b Compare January 10, 2024 20:21
@pro-wh pro-wh force-pushed the pro-wh/feature/roothash2 branch 2 times, most recently from fc4c64d to 074f83d Compare March 29, 2024 22:53
Copy link
Contributor

@mitjat mitjat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM in general; I just have a few questions where I want to make sure the answers are not hiding surprises.

storage/oasis/nodeapi/eden/node.go Show resolved Hide resolved
storage/oasis/nodeapi/eden/node.go Outdated Show resolved Hide resolved
analyzer/consensus/registration.go Outdated Show resolved Hide resolved
analyzer/consensus/messages.go Outdated Show resolved Hide resolved
analyzer/consensus/messages.go Outdated Show resolved Hide resolved
analyzer/consensus/data_fetch.go Outdated Show resolved Hide resolved
analyzer/consensus/consensus.go Show resolved Hide resolved
@pro-wh pro-wh force-pushed the pro-wh/feature/roothash2 branch 3 times, most recently from 65a053d to 7ae4f96 Compare April 9, 2024 22:28
@pro-wh pro-wh changed the base branch from main to pro-wh/feature/categorize April 9, 2024 22:29
Base automatically changed from pro-wh/feature/categorize to main April 10, 2024 19:45
@pro-wh pro-wh merged commit 8024fbd into main Apr 10, 2024
14 checks passed
@pro-wh pro-wh deleted the pro-wh/feature/roothash2 branch April 10, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants