Temporarily disable committee address checks

oasisprotocol · Dec 17, 2019 · a9a532e · a9a532e
1 parent af6600b
commit a9a532e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/go/registry/api/api.go b/go/registry/api/api.go
@@ -491,12 +491,14 @@ func VerifyRegisterNodeArgs( // nolint: gocyclo
 	}
 	committeeAddressRequired := n.HasRoles(CommitteeAddressRequiredRoles)
 	if err := verifyAddresses(params, committeeAddressRequired, n.Committee.Addresses); err != nil {
+		// XXX: Validate committee addresses after existing deployments have cleared up registry.
+		// https://github.com/oasislabs/oasis-core/issues/2428
 		addrs, _ := json.Marshal(n.Committee.Addresses)
-		logger.Error("RegisterNode: missing/invalid committee addresses",
+		logger.Warn("RegisterNode: missing/invalid committee addresses",
 			"node", n,
 			"committee_addrs", addrs,
 		)
-		return nil, err
+		//return nil, err
 	}
 
 	// Validate P2PInfo.

diff --git a/go/registry/tests/tester.go b/go/registry/tests/tester.go
@@ -143,9 +143,11 @@ func testRegistryEntityNodes( // nolint: gocyclo
 					require.Equal(err, api.ErrInvalidArgument)
 				}
 
-				err = v.Register(consensus, v.SignedInvalidRegistration2)
-				require.Error(err, "register committee node without committee addresses")
-				require.Equal(err, api.ErrInvalidArgument)
+				// XXX: Validate committee addresses after existing deployments have cleared up registry.
+				// https://github.com/oasislabs/oasis-core/issues/2428
+				// err = v.Register(consensus, v.SignedInvalidRegistration2)
+				// require.Error(err, "register committee node without committee addresses")
+				// require.Equal(err, api.ErrInvalidArgument)
 
 				err = v.Register(consensus, v.SignedInvalidRegistration3)
 				require.Error(err, "register committee node without committee certificate")