Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node: Don't bypass Stop in newNode failure handler #2966

Merged
merged 1 commit into from
Jun 1, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 1, 2020

Missed this in #2964 😞

@kostko kostko force-pushed the kostko/fix/more-node-stop branch from 088daba to a5cffd0 Compare June 1, 2020 16:29
@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #2966 into master will increase coverage by 0.07%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2966      +/-   ##
==========================================
+ Coverage   68.30%   68.37%   +0.07%     
==========================================
  Files         361      361              
  Lines       35231    35231              
==========================================
+ Hits        24065    24090      +25     
+ Misses       8057     8036      -21     
+ Partials     3109     3105       -4     
Impacted Files Coverage Δ
go/oasis-node/cmd/node/node.go 54.88% <75.00%> (+0.46%) ⬆️
go/storage/metrics.go 78.26% <0.00%> (-9.79%) ⬇️
go/storage/api/root_cache.go 70.11% <0.00%> (-4.60%) ⬇️
.../consensus/tendermint/apps/epochtime_mock/state.go 78.72% <0.00%> (-4.26%) ⬇️
go/storage/mkvs/tree.go 89.28% <0.00%> (-3.58%) ⬇️
go/storage/database/database.go 70.58% <0.00%> (-3.37%) ⬇️
go/storage/mkvs/lookup.go 73.46% <0.00%> (-2.05%) ⬇️
go/storage/mkvs/syncer/proof.go 83.92% <0.00%> (-1.79%) ⬇️
go/consensus/tendermint/apps/staking/fees.go 45.98% <0.00%> (-1.46%) ⬇️
go/consensus/tendermint/apps/staking/staking.go 54.28% <0.00%> (-1.43%) ⬇️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 603e3d8...a5cffd0. Read the comment docs.

@kostko kostko merged commit 9865f5a into master Jun 1, 2020
@kostko kostko deleted the kostko/fix/more-node-stop branch June 1, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant