Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/oasis-node: Make sure the node only tries to stop once #2964

Merged
merged 1 commit into from Jun 1, 2020

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 1, 2020

No description provided.

@kostko kostko force-pushed the kostko/fix/node-stop-once branch 2 times, most recently from 40c2595 to 03a0e7c Compare June 1, 2020 12:56
@kostko kostko marked this pull request as ready for review June 1, 2020 12:56
@codecov
Copy link

codecov bot commented Jun 1, 2020

Codecov Report

Merging #2964 into master will increase coverage by 0.12%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2964      +/-   ##
==========================================
+ Coverage   68.30%   68.43%   +0.12%     
==========================================
  Files         361      361              
  Lines       35231    35231              
==========================================
+ Hits        24065    24110      +45     
+ Misses       8057     8026      -31     
+ Partials     3109     3095      -14     
Impacted Files Coverage Δ
go/oasis-node/cmd/node/node.go 51.62% <100.00%> (-2.80%) ⬇️
go/consensus/tendermint/abci/mux.go 62.90% <0.00%> (-6.00%) ⬇️
go/consensus/tendermint/abci/state.go 65.81% <0.00%> (-2.19%) ⬇️
go/worker/common/p2p/p2p.go 64.41% <0.00%> (-1.81%) ⬇️
go/storage/mkvs/syncer/proof.go 83.92% <0.00%> (-1.79%) ⬇️
go/consensus/tendermint/apps/staking/fees.go 45.98% <0.00%> (-1.46%) ⬇️
go/consensus/tendermint/apps/staking/staking.go 54.28% <0.00%> (-1.43%) ⬇️
go/storage/mkvs/cache.go 82.97% <0.00%> (-0.86%) ⬇️
...o/consensus/tendermint/apps/staking/state/state.go 58.25% <0.00%> (-0.40%) ⬇️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25c748f...2144f68. Read the comment docs.

This could previously result in a panic during shutdown.
@kostko kostko force-pushed the kostko/fix/node-stop-once branch from 03a0e7c to 2144f68 Compare June 1, 2020 14:59
@kostko kostko merged commit 603e3d8 into master Jun 1, 2020
@kostko kostko deleted the kostko/fix/node-stop-once branch June 1, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants