RequestShutdown: fix shutdown if registration never succeeded #4595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrus
force-pushed
the
ptrus/fix/registration-shutdown
branch
2 times, most recently
from
60b7e07
to
2280d6b
Compare
ptrus
requested review from
kostko,
Yawning,
peterjgilbert and
pro-wh
as code owners
ptrus
force-pushed
the
ptrus/fix/registration-shutdown
branch
from
2280d6b
to
3427760
Compare
kostko
approved these changes
Mar 23, 2022
Yawning
approved these changes
Mar 23, 2022
ptrus
force-pushed
the
ptrus/fix/registration-shutdown
branch
from
3427760
to
6877d99
Compare
|
Needs backport ;_; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #4571 and added an explicit e2e test.