Add archive mode support #4571

ptrus · 2022-03-16T14:28:04Z

TODO:

include runtimes in the archive_api e2e test
also test starting a node in archive mode after reaching halt or upgrade epoch
deduplicate some of the duplicated code between archive and full node (archive.go and full.go)
update instructions to enable archive mode to the changelog fragment
~~wait for Bump Tendermint #4427 to be merged and rebase~~

kostko

There still seems to be quite some duplication in the archive node implementation (e.g., get status, converting heights, getting blocks, results, light blocks, parameters, ...), could those things be extracted as well? You could make a common struct that could be embedded into both archive and full node implementations.

go/oasis-test-runner/oasis/oasis.go

codecov · 2022-03-17T13:19:34Z

Codecov Report

Merging #4571 (51e18d5) into master (d34cb93) will increase coverage by 0.40%.
The diff coverage is 71.00%.

@@            Coverage Diff             @@
##           master    #4571      +/-   ##
==========================================
+ Coverage   66.53%   66.94%   +0.40%     
==========================================
  Files         447      448       +1     
  Lines       50065    50246     +181     
==========================================
+ Hits        33313    33639     +326     
+ Misses      12587    12441     -146     
- Partials     4165     4166       +1

Impacted Files	Coverage Δ
go/consensus/api/transaction/transaction.go	`44.85% <ø> (ø)`
go/consensus/tendermint/api/api.go	`83.83% <ø> (ø)`
go/consensus/tendermint/full/services.go	`74.81% <16.66%> (-6.73%)`	⬇️
go/consensus/api/submission.go	`60.86% <25.00%> (-3.42%)`	⬇️
go/oasis-node/cmd/node/node.go	`53.97% <33.33%> (-0.33%)`	⬇️
go/upgrade/upgrade.go	`63.84% <50.00%> (+0.20%)`	⬆️
go/consensus/tendermint/full/common.go	`68.09% <68.09%> (ø)`
go/consensus/tendermint/full/full.go	`65.09% <70.27%> (+1.89%)`	⬆️
go/consensus/tendermint/full/archive.go	`78.51% <78.51%> (ø)`
go/consensus/tendermint/tendermint.go	`80.95% <83.33%> (-3.67%)`	⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8862481...51e18d5. Read the comment docs.

ptrus · 2022-03-21T08:49:18Z

There still seems to be quite some duplication in the archive node implementation (e.g., get status, converting heights, getting blocks, results, light blocks, parameters, ...), could those things be extracted as well? You could make a common struct that could be embedded into both archive and full node implementations.

I tried out how this would look (see latest commit), it's still a bit messy, but I think most of the code can be dedpulicated. Will clean it up a bit more.

go/consensus/tendermint/common/common.go

go/consensus/tendermint/full/light.go

go/consensus/tendermint/full/full.go

Yawning

The screaming you hear is, andrej when his branch has all the conflicts.

Yawning · 2022-03-23T08:14:57Z

go/consensus/tendermint/full/archive.go

+		OwnTxSigner:         srv.identity.NodeSigner.Public(),
+		DisableCheckpointer: true,
+		InitialHeight:       uint64(srv.genesis.Height),
+		// ReadOnly should actually be preferable for archive node but this fails with:


This is a badger issue (https://discuss.dgraph.io/t/read-only-log-truncate-required-to-run-db/16444/2).

Yawning · 2022-03-23T08:17:20Z

.changelog/4571.bugfix.md

@@ -0,0 +1,4 @@
+RequestShutdown: fix shutdown if registration never succeeded


Can this get a backport to 22.x?

Yeah makes sense, I'll also extract this into a separate PR, as this PR will wait for andrej's PR to be merged first, so it might take some more time.

ptrus · 2022-03-23T08:32:44Z

The screaming you hear is, andrej when his branch has all the conflicts.

Actually thats me 😬 as i'll wait for his PR to get merged first.

nftgeek · 2022-04-15T22:38:36Z

Hi When will this feature get ready? @ptrus

Yawning · 2022-04-16T00:05:58Z

Hi When will this feature get ready? @ptrus

3 days ago (#4608), assuming you are interested in being able to query state from Cobalt.

nftgeek · 2022-04-16T00:10:37Z

We are interested in running archive oasis nodes with full blockchain history. we can now, correct?
Any detailed documentation on this topic?

go/consensus/api/api.go

go/oasis-node/cmd/node/node.go

go/consensus/api/api_test.go

ptrus force-pushed the ptrus/feature/archive-node branch 13 times, most recently from 2976dcd to 9acded0 Compare March 17, 2022 10:38

ptrus added the s:ready-ci Status: ready for CI label Mar 17, 2022

ptrus force-pushed the ptrus/feature/archive-node branch 3 times, most recently from dd24376 to 1b0e7c7 Compare March 17, 2022 12:14

ptrus marked this pull request as ready for review March 17, 2022 12:15

ptrus requested review from kostko, Yawning, peterjgilbert and pro-wh as code owners March 17, 2022 12:15

kostko reviewed Mar 17, 2022

View reviewed changes

go/oasis-test-runner/oasis/oasis.go Outdated Show resolved Hide resolved

ptrus marked this pull request as draft March 21, 2022 08:16

ptrus force-pushed the ptrus/feature/archive-node branch 3 times, most recently from 1ddb7e1 to c7f61d2 Compare March 21, 2022 08:48

ptrus force-pushed the ptrus/feature/archive-node branch from c7f61d2 to a1daea8 Compare March 21, 2022 09:05

kostko reviewed Mar 22, 2022

View reviewed changes

go/consensus/tendermint/common/common.go Outdated Show resolved Hide resolved

go/consensus/tendermint/full/light.go Outdated Show resolved Hide resolved

go/consensus/tendermint/full/full.go Outdated Show resolved Hide resolved

go/consensus/tendermint/full/full.go Show resolved Hide resolved

ptrus force-pushed the ptrus/feature/archive-node branch 2 times, most recently from 5305d0c to 5976af7 Compare March 22, 2022 13:54

Yawning reviewed Mar 23, 2022

View reviewed changes

ptrus mentioned this pull request Mar 23, 2022

RequestShutdown: fix shutdown if registration never succeeded #4595

Merged

ptrus force-pushed the ptrus/feature/archive-node branch 2 times, most recently from 69b5b45 to 5ca789a Compare March 24, 2022 12:08

ptrus mentioned this pull request Mar 28, 2022

[BACKPORT/21.3.x]: Add archive mode support #4608

Merged

ptrus force-pushed the ptrus/feature/archive-node branch from 5ca789a to f4b6f3f Compare March 28, 2022 07:35

ptrus force-pushed the ptrus/feature/archive-node branch from f4b6f3f to 7e88bc7 Compare April 8, 2022 14:24

ptrus marked this pull request as draft April 12, 2022 19:13

ptrus force-pushed the ptrus/feature/archive-node branch 3 times, most recently from ccf1495 to 5947500 Compare May 27, 2022 09:21

ptrus marked this pull request as ready for review May 27, 2022 10:19

ptrus force-pushed the ptrus/feature/archive-node branch from 5947500 to 056aa80 Compare May 31, 2022 07:30

kostko reviewed May 31, 2022

View reviewed changes

go/consensus/api/api.go Outdated Show resolved Hide resolved

go/oasis-node/cmd/node/node.go Outdated Show resolved Hide resolved

ptrus force-pushed the ptrus/feature/archive-node branch from 056aa80 to 6292854 Compare June 1, 2022 09:22

kostko reviewed Jun 1, 2022

View reviewed changes

go/consensus/api/api_test.go Outdated Show resolved Hide resolved

Add archive mode support

51e18d5

ptrus force-pushed the ptrus/feature/archive-node branch from 6292854 to 51e18d5 Compare June 1, 2022 10:12

kostko approved these changes Jun 1, 2022

View reviewed changes

ptrus merged commit 29a9709 into master Jun 1, 2022

ptrus deleted the ptrus/feature/archive-node branch June 1, 2022 10:48

kostko mentioned this pull request Jun 21, 2022

go/consensus/tendermint/full: Unify started indicators #4809

Merged

ptrus mentioned this pull request Jan 26, 2023

Config rework #5070

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add archive mode support #4571

Add archive mode support #4571

ptrus commented Mar 16, 2022 •

edited

Loading

kostko left a comment

codecov bot commented Mar 17, 2022 •

edited

Loading

ptrus commented Mar 21, 2022

Yawning left a comment

Yawning Mar 23, 2022

Yawning Mar 23, 2022

ptrus Mar 23, 2022

ptrus commented Mar 23, 2022

nftgeek commented Apr 15, 2022

Yawning commented Apr 16, 2022

nftgeek commented Apr 16, 2022

		@@ -0,0 +1,4 @@
		RequestShutdown: fix shutdown if registration never succeeded

Add archive mode support #4571

Add archive mode support #4571

Conversation

ptrus commented Mar 16, 2022 • edited Loading

kostko left a comment

Choose a reason for hiding this comment

codecov bot commented Mar 17, 2022 • edited Loading

Codecov Report

ptrus commented Mar 21, 2022

Yawning left a comment

Choose a reason for hiding this comment

Yawning Mar 23, 2022

Choose a reason for hiding this comment

Yawning Mar 23, 2022

Choose a reason for hiding this comment

ptrus Mar 23, 2022

Choose a reason for hiding this comment

ptrus commented Mar 23, 2022

nftgeek commented Apr 15, 2022

Yawning commented Apr 16, 2022

nftgeek commented Apr 16, 2022

ptrus commented Mar 16, 2022 •

edited

Loading

codecov bot commented Mar 17, 2022 •

edited

Loading