Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/control: Show the debug option statuses in the control output #4634

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Apr 4, 2022

No description provided.

@Yawning Yawning force-pushed the yawning/feature/status-show-debug branch from af064d9 to b302a16 Compare April 4, 2022 10:15
@Yawning Yawning marked this pull request as ready for review April 4, 2022 10:15
@Yawning Yawning force-pushed the yawning/feature/status-show-debug branch from b302a16 to c460a7a Compare April 4, 2022 10:27
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #4634 (c460a7a) into master (12dd4f8) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head c460a7a differs from pull request most recent head 46fc737. Consider uploading reports for the commit 46fc737 to get more accurate results

@@            Coverage Diff             @@
##           master    #4634      +/-   ##
==========================================
- Coverage   67.01%   66.98%   -0.03%     
==========================================
  Files         431      431              
  Lines       48799    48775      -24     
==========================================
- Hits        32701    32673      -28     
- Misses      12062    12069       +7     
+ Partials     4036     4033       -3     
Impacted Files Coverage Δ
go/control/control.go 60.00% <100.00%> (+3.24%) ⬆️
go/worker/common/committee/p2p.go 70.00% <0.00%> (-6.67%) ⬇️
.../worker/compute/executor/committee/transactions.go 82.69% <0.00%> (-3.47%) ⬇️
go/sentry/api/grpc.go 40.62% <0.00%> (-3.13%) ⬇️
...ensus/tendermint/apps/staking/state/accumulator.go 67.16% <0.00%> (-2.99%) ⬇️
go/storage/mkvs/insert.go 87.75% <0.00%> (-2.73%) ⬇️
go/oasis-node/cmd/ias/auth_registry.go 65.81% <0.00%> (-2.57%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 65.27% <0.00%> (-2.10%) ⬇️
go/storage/mkvs/overlay.go 73.78% <0.00%> (-1.95%) ⬇️
go/oasis-node/cmd/stake/delegations.go 78.99% <0.00%> (-1.69%) ⬇️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c73122...46fc737. Read the comment docs.

@Yawning Yawning force-pushed the yawning/feature/status-show-debug branch from c460a7a to 46fc737 Compare April 4, 2022 11:33
@Yawning Yawning enabled auto-merge April 4, 2022 11:33
@Yawning Yawning merged commit 0675805 into master Apr 4, 2022
@Yawning Yawning deleted the yawning/feature/status-show-debug branch April 4, 2022 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants