-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
runtime: Verify RAK in consensus state when serving requests #4741
Conversation
30e4876
to
2a95793
Compare
Codecov Report
@@ Coverage Diff @@
## master #4741 +/- ##
==========================================
- Coverage 66.92% 66.77% -0.16%
==========================================
Files 441 441
Lines 49340 49348 +8
==========================================
- Hits 33023 32952 -71
- Misses 12262 12317 +55
- Partials 4055 4079 +24
Continue to review full report at Codecov.
|
c4fe95a
to
44e9a51
Compare
runtime/src/consensus/registry.rs
Outdated
/// Information for this node's participation in the old PVSS based random beacon protocol. | ||
/// Deprecated. | ||
#[cbor(optional, default)] | ||
pub beacon: Option<Vec<u8>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sigh, there's a PR that gets rid of this on the Go side, but apparently "no breaking changes" or something, so the branch is rotting.
44e9a51
to
034ea80
Compare
034ea80
to
723d4d5
Compare
dce48eb
to
d1c93b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, I would just make sure that the RAK is advertised for the correct runtime ID/version combination.
d1c93b7
to
237e215
Compare
Going to do one more CI run with all SGX tests enabled on this branch, before merging. |
a2230d7
to
cc6ad12
Compare
cc6ad12
to
33553b1
Compare
No description provided.