Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/keymanager: Add key manager worker metrics #4877

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

peternose
Copy link
Contributor

Currently the key manager worker lacks metrics that would enable the operator to gain some useful insights into its operation. We should add the following metrics:

  • Number of key manager policy updates
  • Number of compute runtimes using the key manager
  • Number of remote EnclaveRPC requests via P2P (separate per method)

@peternose peternose force-pushed the peternose/feature/keymanager-worker-metrics branch from 72987a3 to 2d8912f Compare August 5, 2022 11:38
@peternose peternose added golang c:instrumentation Category: metrics and tracing labels Aug 5, 2022
@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #4877 (e39dc3e) into master (d0bb246) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4877      +/-   ##
==========================================
- Coverage   66.54%   66.45%   -0.10%     
==========================================
  Files         452      454       +2     
  Lines       50418    50431      +13     
==========================================
- Hits        33551    33514      -37     
- Misses      12705    12743      +38     
- Partials     4162     4174      +12     
Impacted Files Coverage Δ
go/worker/keymanager/init.go 61.53% <100.00%> (+0.60%) ⬆️
go/worker/keymanager/metrics.go 100.00% <100.00%> (ø)
go/worker/keymanager/p2p/metrics.go 100.00% <100.00%> (ø)
go/worker/keymanager/p2p/server.go 80.00% <100.00%> (+2.22%) ⬆️
go/worker/keymanager/worker.go 64.01% <100.00%> (+0.15%) ⬆️
.../worker/compute/executor/committee/transactions.go 81.81% <0.00%> (-6.82%) ⬇️
go/worker/common/p2p/dispatch.go 71.52% <0.00%> (-5.56%) ⬇️
go/runtime/host/multi/multi.go 70.58% <0.00%> (-3.68%) ⬇️
go/worker/common/committee/keymanager.go 88.33% <0.00%> (-3.34%) ⬇️
go/runtime/registry/host.go 69.38% <0.00%> (-2.86%) ⬇️
... and 13 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@kostko kostko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good!

One thing that you need to add is a changelog fragment that describes what changes are there when making a release.

@peternose peternose force-pushed the peternose/feature/keymanager-worker-metrics branch 3 times, most recently from ca068de to cb436ef Compare August 8, 2022 08:59
@peternose peternose force-pushed the peternose/feature/keymanager-worker-metrics branch from cb436ef to e39dc3e Compare August 9, 2022 13:22
@peternose peternose merged commit bef388f into master Aug 9, 2022
@peternose peternose deleted the peternose/feature/keymanager-worker-metrics branch August 9, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:instrumentation Category: metrics and tracing golang
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants