Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADR 0002: Go Modules Compatible Git Tags #3242

Merged
merged 1 commit into from Sep 9, 2020
Merged

Conversation

tjanez
Copy link
Member

@tjanez tjanez commented Sep 4, 2020

No description provided.

@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #3242 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3242      +/-   ##
==========================================
- Coverage   67.68%   67.40%   -0.29%     
==========================================
  Files         370      370              
  Lines       36449    36386      -63     
==========================================
- Hits        24671    24525     -146     
- Misses       8597     8688      +91     
+ Partials     3181     3173       -8     
Impacted Files Coverage Δ
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/consensus/tendermint/api/api.go 77.65% <0.00%> (-9.58%) ⬇️
go/storage/metrics.go 77.02% <0.00%> (-8.11%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
go/consensus/tendermint/epochtime/epochtime.go 85.71% <0.00%> (-7.94%) ⬇️
go/consensus/tendermint/apps/staking/query.go 49.09% <0.00%> (-7.28%) ⬇️
go/storage/api/root_cache.go 74.60% <0.00%> (-6.35%) ⬇️
go/staking/api/grpc.go 55.03% <0.00%> (-6.21%) ⬇️
go/oasis-node/cmd/node/control.go 47.61% <0.00%> (-4.33%) ⬇️
go/storage/database/database.go 71.00% <0.00%> (-4.00%) ⬇️
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3af7611...c11e568. Read the comment docs.

@tjanez tjanez force-pushed the tjanez/go-modules-git-tags branch 2 times, most recently from 4d58c78 to f29ef8a Compare September 4, 2020 16:37
@tjanez tjanez marked this pull request as ready for review September 4, 2020 16:37
@kostko kostko added the c:docs/adr Category: documentation/ADR label Sep 7, 2020
@kostko kostko linked an issue Sep 7, 2020 that may be closed by this pull request
Copy link
Member

@ptrus ptrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@peterjgilbert
Copy link
Contributor

Discussion on 2020/09/08: approved

Copy link
Contributor

@pro-wh pro-wh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will make it easier for dependent projects

@tjanez tjanez merged commit e1a7974 into master Sep 9, 2020
@tjanez tjanez deleted the tjanez/go-modules-git-tags branch September 9, 2020 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:docs/adr Category: documentation/ADR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add go/ prefix to release tags
5 participants