Bump Tendermint #4427
Closed
Bump Tendermint #4427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abukosek
force-pushed
the
andrej/feature/tenderbump-35
branch
from
eb0577a
to
a7b1976
Compare
Yawning
reviewed
Jan 12, 2022
| @@ -206,8 +206,10 @@ func EventsFromTendermint( | |||
| } | |||
|
|
|||
| for _, pair := range tmEv.GetAttributes() { | |||
| key := pair.GetKey() | |||
| val := pair.GetValue() | |||
| key, val, err := tmapi.DecodeEventKVPair(pair.GetKey(), pair.GetValue()) | |||
There was a problem hiding this comment.
Should we also have tmapi.DecodeEventPair(pair)?
abukosek
force-pushed
the
andrej/feature/tenderbump-35
branch
10 times, most recently
from
58fe2ff
to
344d9fc
Compare
Yawning
reviewed
Jan 13, 2022
abukosek
force-pushed
the
andrej/feature/tenderbump-35
branch
6 times, most recently
from
c1c786d
to
4218ffe
Compare
Yawning
reviewed
Jan 18, 2022
abukosek
force-pushed
the
andrej/feature/tenderbump-35
branch
9 times, most recently
from
386a218
to
f4cc406
Compare
abukosek
force-pushed
the
andrej/feature/tenderbump-35
branch
from
f4cc406
to
afd2144
Compare
abukosek
force-pushed
the
andrej/feature/tenderbump-35
branch
2 times, most recently
from
80eb46c
to
2fac3d8
Compare
abukosek
force-pushed
the
andrej/feature/tenderbump-35
branch
18 times, most recently
from
c35b520
to
9a29cff
Compare
abukosek
force-pushed
the
andrej/feature/tenderbump-35
branch
5 times, most recently
from
714b1da
to
c2719e6
Compare
abukosek
force-pushed
the
andrej/feature/tenderbump-35
branch
from
c2719e6
to
107405d
Compare
|
Tendermint 0.35 release is broken beyond repair and will not be fixed by upstream: Closing this PR because of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4249 and closes #4326.
TODO:
- [ ] add support for tx prioritization-> will be done in a separate PR based on the existing 0.34- [ ] wait for tendermint to fix their stuff-> 0.35 release is broken beyond repair and will not be fixed by upstream