Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/runtime: Switch to a unified bundle format #4474

Merged
merged 7 commits into from
Feb 21, 2022
Merged

Conversation

Yawning
Copy link
Contributor

@Yawning Yawning commented Feb 11, 2022

  • Define the file format
  • Implement the file format
  • Switch the providers to use the file format
  • Write a tool to create files in the format
  • Unbreak the e2e tests
    • Everything that isn't the runtime trust root test
    • The runtime trust root test

Test support was implemented in the worst possible way, in an attempt to minimize code changes by having the test harness dynamically generate the runtime bundles when provisioning the network. While it is possible to make the tests actually use pre-generated bundles, there are a handful of tests that create arbitrary runtimes as part of the test process, which will complicate matters.

Implements #4469

@Yawning Yawning force-pushed the yawning/feature/4469 branch 19 times, most recently from 17aa343 to 88127f7 Compare February 18, 2022 13:01
@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #4474 (284a79f) into master (6983322) will decrease coverage by 0.40%.
The diff coverage is 65.45%.

❗ Current head 284a79f differs from pull request most recent head 198d165. Consider uploading reports for the commit 198d165 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4474      +/-   ##
==========================================
- Coverage   69.01%   68.60%   -0.41%     
==========================================
  Files         424      425       +1     
  Lines       47365    47560     +195     
==========================================
- Hits        32688    32629      -59     
- Misses      10676    10884     +208     
- Partials     4001     4047      +46     
Impacted Files Coverage Δ
go/runtime/host/sgx/sgx.go 71.07% <0.00%> (ø)
go/runtime/bundle/bundle.go 61.72% <61.72%> (ø)
go/runtime/registry/config.go 70.17% <73.46%> (+2.78%) ⬆️
go/runtime/host/mock/mock.go 92.38% <100.00%> (ø)
go/runtime/host/sandbox/sandbox.go 65.84% <100.00%> (-5.44%) ⬇️
go/runtime/registry/registry.go 74.03% <100.00%> (-0.71%) ⬇️
...nsensus/tendermint/apps/keymanager/transactions.go 0.00% <0.00%> (-52.78%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/consensus/tendermint/api/errors.go 86.66% <0.00%> (-13.34%) ⬇️
go/worker/common/committee/p2p.go 78.94% <0.00%> (-10.53%) ⬇️
... and 36 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbac7ab...198d165. Read the comment docs.

@Yawning Yawning force-pushed the yawning/feature/4469 branch 3 times, most recently from 10d4931 to 284a79f Compare February 18, 2022 13:46
@Yawning Yawning marked this pull request as ready for review February 18, 2022 13:46
go/oasis-test-runner/cmd/bundle/bundle.go Outdated Show resolved Hide resolved
.changelog/4469.feature.md Show resolved Hide resolved
go/oasis-test-runner/oasis/runtime.go Show resolved Hide resolved
go/runtime/bundle/bundle.go Show resolved Hide resolved
@Yawning Yawning force-pushed the yawning/feature/4469 branch 3 times, most recently from 7eff32e to b8236ab Compare February 21, 2022 11:29
Yawning and others added 7 commits February 21, 2022 11:31
In case the cached state root value doesn't match, force full
verification instead of reporting failure. Cache entries may be
optimistic (e.g. they assume the round committed) so in case of a
failed round they may be incorrect.

We now force a full verification in this case.
@Yawning Yawning merged commit d81cce2 into master Feb 21, 2022
@Yawning Yawning deleted the yawning/feature/4469 branch February 21, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants