-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/runtime: Switch to a unified bundle format #4474
Conversation
17aa343
to
88127f7
Compare
Codecov Report
@@ Coverage Diff @@
## master #4474 +/- ##
==========================================
- Coverage 69.01% 68.60% -0.41%
==========================================
Files 424 425 +1
Lines 47365 47560 +195
==========================================
- Hits 32688 32629 -59
- Misses 10676 10884 +208
- Partials 4001 4047 +46
Continue to review full report at Codecov.
|
10d4931
to
284a79f
Compare
3570d96
to
7b842cc
Compare
7eff32e
to
b8236ab
Compare
In case the cached state root value doesn't match, force full verification instead of reporting failure. Cache entries may be optimistic (e.g. they assume the round committed) so in case of a failed round they may be incorrect. We now force a full verification in this case.
b8236ab
to
198d165
Compare
Test support was implemented in the worst possible way, in an attempt to minimize code changes by having the test harness dynamically generate the runtime bundles when provisioning the network. While it is possible to make the tests actually use pre-generated bundles, there are a handful of tests that create arbitrary runtimes as part of the test process, which will complicate matters.
Implements #4469