Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clear tx pool on epoch transitions, add txsync protocol #4579

Merged
merged 1 commit into from
Mar 21, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Mar 18, 2022

No description provided.

@kostko kostko force-pushed the kostko/fix/txpool-noclear-limits branch 4 times, most recently from ae504b5 to d2c2489 Compare March 21, 2022 10:15
@codecov
Copy link

codecov bot commented Mar 21, 2022

Codecov Report

Merging #4579 (d2c2489) into master (afabfc6) will increase coverage by 0.17%.
The diff coverage is 71.65%.

❗ Current head d2c2489 differs from pull request most recent head b2f9626. Consider uploading reports for the commit b2f9626 to get more accurate results

@@            Coverage Diff             @@
##           master    #4579      +/-   ##
==========================================
+ Coverage   66.86%   67.03%   +0.17%     
==========================================
  Files         424      427       +3     
  Lines       48069    48115      +46     
==========================================
+ Hits        32141    32256     +115     
+ Misses      11982    11925      -57     
+ Partials     3946     3934      -12     
Impacted Files Coverage Δ
go/worker/common/p2p/rpc/client.go 78.65% <41.66%> (-2.68%) ⬇️
go/worker/common/p2p/txsync/client.go 58.33% <58.33%> (ø)
go/runtime/txpool/txpool.go 78.81% <66.66%> (+2.19%) ⬆️
go/worker/common/p2p/txsync/server.go 69.23% <69.23%> (ø)
.../worker/compute/executor/committee/transactions.go 82.69% <82.69%> (ø)
go/worker/common/committee/node.go 68.60% <100.00%> (+0.67%) ⬆️
go/worker/common/config.go 72.91% <100.00%> (-1.09%) ⬇️
go/worker/compute/executor/committee/node.go 71.27% <100.00%> (-0.21%) ⬇️
go/worker/common/committee/p2p.go 70.00% <0.00%> (-10.00%) ⬇️
go/worker/common/p2p/dispatch.go 71.52% <0.00%> (-5.56%) ⬇️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac71d6...b2f9626. Read the comment docs.

@kostko kostko force-pushed the kostko/fix/txpool-noclear-limits branch from d2c2489 to b2f9626 Compare March 21, 2022 10:46
@kostko kostko marked this pull request as ready for review March 21, 2022 10:46
@kostko kostko enabled auto-merge March 21, 2022 11:21
@kostko kostko merged commit 935c074 into master Mar 21, 2022
@kostko kostko deleted the kostko/fix/txpool-noclear-limits branch March 21, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants