Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/common: Properly handle dynamic key manager configuration #4715

Merged
merged 2 commits into from
May 3, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Apr 30, 2022

Since the runtime can go from having no key manager configured to having
one, the worker node should handle this correctly.

@kostko kostko force-pushed the kostko/feature/rt-km-dynamic-update branch 2 times, most recently from b9a6b0f to 9d7b3ad Compare April 30, 2022 10:35
@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #4715 (22ee108) into master (cf1783b) will decrease coverage by 0.60%.
The diff coverage is 90.56%.

❗ Current head 22ee108 differs from pull request most recent head eeee071. Consider uploading reports for the commit eeee071 to get more accurate results

@@            Coverage Diff             @@
##           master    #4715      +/-   ##
==========================================
- Coverage   67.47%   66.86%   -0.61%     
==========================================
  Files         439      440       +1     
  Lines       49183    49224      +41     
==========================================
- Hits        33186    32916     -270     
- Misses      11970    12252     +282     
- Partials     4027     4056      +29     
Impacted Files Coverage Δ
go/worker/common/committee/keymanager.go 89.47% <89.47%> (ø)
go/worker/compute/executor/committee/node.go 71.41% <90.00%> (+0.06%) ⬆️
go/worker/common/committee/node.go 59.38% <100.00%> (-1.48%) ⬇️
go/worker/common/committee/runtime_host.go 50.00% <100.00%> (-8.34%) ⬇️
go/ias/http/http.go 20.33% <0.00%> (-44.07%) ⬇️
go/oasis-node/cmd/common/metrics/disk.go 65.51% <0.00%> (-20.69%) ⬇️
go/keymanager/api/policy_sgx.go 33.33% <0.00%> (-13.34%) ⬇️
go/runtime/host/sgx/epid.go 63.79% <0.00%> (-10.35%) ⬇️
go/runtime/host/sandbox/sandbox.go 66.54% <0.00%> (-10.22%) ⬇️
go/oasis-node/cmd/common/metrics/resource.go 84.00% <0.00%> (-8.00%) ⬇️
... and 54 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a0058a...eeee071. Read the comment docs.

@kostko kostko marked this pull request as ready for review April 30, 2022 11:02
@kostko kostko force-pushed the kostko/feature/rt-km-dynamic-update branch from 9d7b3ad to 22ee108 Compare April 30, 2022 11:02
kostko added 2 commits May 2, 2022 22:07
Since the runtime can go from having no key manager configured to having
one, the worker node should handle this correctly.
@kostko kostko force-pushed the kostko/feature/rt-km-dynamic-update branch from 22ee108 to eeee071 Compare May 2, 2022 20:07
@kostko kostko enabled auto-merge May 2, 2022 20:34
@kostko kostko merged commit d666f80 into master May 3, 2022
@kostko kostko deleted the kostko/feature/rt-km-dynamic-update branch May 3, 2022 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants