Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/consensus/tendermint: Fix liveness tracking for primary+backup #4798

Merged
merged 3 commits into from Oct 14, 2022

Conversation

kostko
Copy link
Member

@kostko kostko commented Jun 14, 2022

In case a node is both primary and backup and doesn't submit a commit
but there was no discrepancy, the node should still be treated as
failed.

This needs to wait until we release 22.2.x.

@kostko kostko added c:bug Category: bug c:breaking/consensus Category: breaking consensus changes labels Jun 14, 2022
@kostko kostko force-pushed the kostko/fix/roothash-multi-fault branch 2 times, most recently from 6e10be7 to c7c5352 Compare June 14, 2022 07:55
@kostko kostko changed the base branch from master to kostko/feature/roothash-multi-fault-test June 14, 2022 07:55
@kostko kostko added the c:roothash Category: root hash service label Jun 14, 2022
Base automatically changed from kostko/feature/roothash-multi-fault-test to master June 14, 2022 08:31
In case a node is both primary and backup and doesn't submit a commit
but there was no discrepancy, the node should still be treated as
failed.
@kostko kostko force-pushed the kostko/fix/roothash-multi-fault branch from c7c5352 to 3a83224 Compare October 14, 2022 12:14
@kostko kostko marked this pull request as ready for review October 14, 2022 12:22
@kostko kostko enabled auto-merge October 14, 2022 12:26
@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #4798 (ed32a55) into master (7d5d0bb) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4798      +/-   ##
==========================================
- Coverage   66.78%   66.73%   -0.06%     
==========================================
  Files         471      471              
  Lines       51613    51614       +1     
==========================================
- Hits        34472    34446      -26     
- Misses      12919    12927       +8     
- Partials     4222     4241      +19     
Impacted Files Coverage Δ
go/common/version/version.go 80.26% <ø> (ø)
go/consensus/tendermint/apps/roothash/roothash.go 73.73% <100.00%> (-1.21%) ⬇️
go/roothash/api/sanity_check.go 60.00% <0.00%> (-8.00%) ⬇️
go/common/grpc/auth/auth.go 94.73% <0.00%> (-5.27%) ⬇️
go/storage/mkvs/remove.go 85.85% <0.00%> (-4.05%) ⬇️
go/common/sgx/common.go 66.01% <0.00%> (-3.89%) ⬇️
go/consensus/tendermint/full/services.go 74.81% <0.00%> (-3.71%) ⬇️
go/common/sgx/aesm/aesm.go 44.13% <0.00%> (-3.29%) ⬇️
go/consensus/tendermint/abci/state.go 72.85% <0.00%> (-2.86%) ⬇️
...nsensus/tendermint/apps/keymanager/transactions.go 52.77% <0.00%> (-2.78%) ⬇️
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kostko kostko merged commit 2fb2c2e into master Oct 14, 2022
@kostko kostko deleted the kostko/fix/roothash-multi-fault branch October 14, 2022 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:breaking/consensus Category: breaking consensus changes c:bug Category: bug c:roothash Category: root hash service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants