Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net-runner: Use 0.1.0 for default fixture.default.runtime.version #4816

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

matevz
Copy link
Member

@matevz matevz commented Jun 22, 2022

Use 0.1.0 instead of 1.0.0 for consistency with runtime tests and initial tutorial code.

@matevz matevz force-pushed the matevz/bugfix/net-runner-change-default-version branch from fc847c6 to 30117e5 Compare June 22, 2022 14:20
@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #4816 (30117e5) into master (bce059b) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4816      +/-   ##
==========================================
- Coverage   66.87%   66.86%   -0.01%     
==========================================
  Files         451      451              
  Lines       50260    50260              
==========================================
- Hits        33609    33606       -3     
- Misses      12487    12490       +3     
  Partials     4164     4164              
Impacted Files Coverage Δ
...onsensus/tendermint/apps/beacon/state/state_vrf.go 73.33% <0.00%> (-13.34%) ⬇️
go/worker/storage/committee/utils.go 92.30% <0.00%> (-7.70%) ⬇️
go/worker/storage/p2p/sync/client.go 86.95% <0.00%> (-4.35%) ⬇️
go/worker/compute/executor/committee/p2p.go 75.00% <0.00%> (-4.17%) ⬇️
go/common/workerpool/workerpool.go 78.46% <0.00%> (-3.08%) ⬇️
go/worker/storage/committee/node.go 77.02% <0.00%> (-1.79%) ⬇️
go/worker/client/service.go 70.58% <0.00%> (-1.31%) ⬇️
go/consensus/tendermint/apps/beacon/backend_vrf.go 58.89% <0.00%> (-0.85%) ⬇️
go/consensus/tendermint/beacon/beacon.go 73.80% <0.00%> (-0.48%) ⬇️
go/worker/storage/committee/checkpoint_sync.go 66.10% <0.00%> (-0.43%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed4b022...30117e5. Read the comment docs.

@matevz matevz merged commit 2e6bd1c into master Jun 23, 2022
@matevz matevz deleted the matevz/bugfix/net-runner-change-default-version branch June 23, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants