Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #4886 - advancedtls Certificate options moved to IdentityOptions #4887

Merged
merged 1 commit into from Aug 12, 2022

Conversation

nyetwurk
Copy link
Contributor

No description provided.

@kostko kostko linked an issue Aug 11, 2022 that may be closed by this pull request
@kostko kostko added the c:deps Category: external dependencies label Aug 11, 2022
@kostko
Copy link
Member

kostko commented Aug 11, 2022

Thanks for the PR! Please add a changelog fragment (can be of type internal).

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #4887 (2bc7d66) into master (fdaa307) will increase coverage by 0.08%.
The diff coverage is 72.65%.

@@            Coverage Diff             @@
##           master    #4887      +/-   ##
==========================================
+ Coverage   66.55%   66.63%   +0.08%     
==========================================
  Files         454      456       +2     
  Lines       50524    50539      +15     
==========================================
+ Hits        33627    33678      +51     
+ Misses      12726    12702      -24     
+ Partials     4171     4159      -12     
Impacted Files Coverage Δ
go/worker/keymanager/api/api.go 32.43% <32.43%> (ø)
go/control/control.go 71.42% <50.00%> (ø)
go/worker/keymanager/status.go 82.60% <82.60%> (ø)
go/common/grpc/credentials.go 74.19% <100.00%> (+1.77%) ⬆️
go/oasis-node/cmd/node/control.go 65.45% <100.00%> (ø)
go/worker/keymanager/init.go 62.12% <100.00%> (+0.58%) ⬆️
go/worker/keymanager/metrics.go 100.00% <100.00%> (ø)
go/worker/keymanager/p2p/metrics.go 100.00% <100.00%> (ø)
go/worker/keymanager/p2p/server.go 80.00% <100.00%> (+2.22%) ⬆️
go/worker/keymanager/worker.go 65.09% <100.00%> (+0.15%) ⬆️
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kostko kostko merged commit ea44d22 into oasisprotocol:master Aug 12, 2022
@nyetwurk nyetwurk deleted the 4886-update-advancedtls branch August 12, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:deps Category: external dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

golang advancedtls no longer has Certificate and GetClientCertificate
2 participants