Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/sgx/ias: Add support for blacklisting GIDs #5113

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

ptrus
Copy link
Member

@ptrus ptrus commented Jan 3, 2023

No description provided.

@codecov
Copy link

codecov bot commented Jan 3, 2023

Codecov Report

Merging #5113 (613c026) into master (d438583) will increase coverage by 0.04%.
The diff coverage is 60.00%.

❗ Current head 613c026 differs from pull request most recent head d94313f. Consider uploading reports for the commit d94313f to get more accurate results

@@            Coverage Diff             @@
##           master    #5113      +/-   ##
==========================================
+ Coverage   66.80%   66.85%   +0.04%     
==========================================
  Files         497      497              
  Lines       53149    53159      +10     
==========================================
+ Hits        35508    35540      +32     
+ Misses      13313    13280      -33     
- Partials     4328     4339      +11     
Impacted Files Coverage Δ
go/registry/api/runtime.go 52.08% <50.00%> (-0.04%) ⬇️
go/common/sgx/ias/avr.go 41.93% <66.66%> (+0.82%) ⬆️
go/scheduler/api/sanity_check.go 71.42% <0.00%> (-4.77%) ⬇️
go/runtime/host/protocol/connection.go 65.03% <0.00%> (-3.76%) ⬇️
.../worker/compute/executor/committee/transactions.go 84.09% <0.00%> (-2.28%) ⬇️
...consensus/tendermint/apps/roothash/transactions.go 69.77% <0.00%> (-2.23%) ⬇️
...nsensus/tendermint/apps/beacon/backend_insecure.go 58.24% <0.00%> (-2.20%) ⬇️
go/consensus/tendermint/apps/beacon/state/state.go 66.66% <0.00%> (-2.16%) ⬇️
go/common/grpc/grpc.go 79.59% <0.00%> (-2.02%) ⬇️
go/runtime/registry/host.go 70.91% <0.00%> (-1.45%) ⬇️
... and 24 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@@ -55,6 +55,8 @@ enum AVRError {
InvalidSignature,
#[error("IAS quotes are disabled by policy")]
Disabled,
#[error("Blacklisted IAS quote GID")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[error("Blacklisted IAS quote GID")]
#[error("blacklisted IAS quote GID")]

@ptrus ptrus force-pushed the ptrus/feature/blacklist-gid branch from 613c026 to d94313f Compare January 3, 2023 13:30
@ptrus ptrus enabled auto-merge January 3, 2023 13:30
@ptrus ptrus merged commit 6aa088f into master Jan 3, 2023
@ptrus ptrus deleted the ptrus/feature/blacklist-gid branch January 3, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants