Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/common/node: Add runtime encryption key (REK) #5125

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

peternose
Copy link
Contributor

@peternose peternose commented Jan 10, 2023

Used attestation signature to authenticate the REK. When computing the signature the new version hashes also REK.

Next (optional) step would be to:

  • move height and signature to CapabilitiesTEE,
  • define custom CBOR marshalling which would copy those two fields from the SGXAttestation v2, and
  • move signature verification to CapabilitiesTEE.

We would probably also need to introduce versioning for CapabilitiesTEE. As this step is more complicated and not needed, I decided to skip it.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #5125 (9c8fb59) into master (1e625b6) will increase coverage by 0.01%.
The diff coverage is 72.72%.

❗ Current head 9c8fb59 differs from pull request most recent head cf222c2. Consider uploading reports for the commit cf222c2 to get more accurate results

@@            Coverage Diff             @@
##           master    #5125      +/-   ##
==========================================
+ Coverage   66.83%   66.85%   +0.01%     
==========================================
  Files         496      496              
  Lines       53271    53275       +4     
==========================================
+ Hits        35606    35619      +13     
+ Misses      13331    13314      -17     
- Partials     4334     4342       +8     
Impacted Files Coverage Δ
...o/consensus/tendermint/apps/scheduler/scheduler.go 72.86% <0.00%> (ø)
go/roothash/api/commitment/txnscheduler.go 50.00% <0.00%> (ø)
go/runtime/host/protocol/types.go 54.54% <ø> (ø)
go/common/node/node.go 71.07% <50.00%> (ø)
go/common/node/sgx.go 78.26% <100.00%> (+0.38%) ⬆️
go/runtime/host/sgx/sgx.go 72.27% <100.00%> (+0.27%) ⬆️
go/runtime/txpool/check_queue.go 86.48% <0.00%> (-13.52%) ⬇️
go/runtime/host/protocol/connection.go 64.28% <0.00%> (-6.02%) ⬇️
go/p2p/rpc/client.go 77.97% <0.00%> (-4.41%) ⬇️
go/common/sgx/common.go 66.01% <0.00%> (-3.89%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternose peternose marked this pull request as ready for review January 10, 2023 14:56
@peternose peternose added c:registry Category: entity/node/runtime registry service golang rust c:key management Category: key management labels Jan 12, 2023
@peternose peternose marked this pull request as draft January 12, 2023 18:24
@peternose peternose force-pushed the peternose/feature/rek branch 2 times, most recently from b2ac7e1 to 2b67fb2 Compare January 13, 2023 12:40
@peternose peternose marked this pull request as ready for review January 13, 2023 13:07
@peternose peternose merged commit e2deeac into master Jan 16, 2023
@peternose peternose deleted the peternose/feature/rek branch January 16, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:key management Category: key management c:registry Category: entity/node/runtime registry service golang rust
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants