keymanager: Add forward-secrecy to ephemeral keys #5158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
force-pushed
the
peternose/feature/ephemeral-keys-forward-secrecy
branch
2 times, most recently
from
ef71046
to
e7f6b5a
Compare
Codecov Report
@@ Coverage Diff @@
## master #5158 +/- ##
==========================================
- Coverage 61.41% 61.40% -0.02%
==========================================
Files 511 512 +1
Lines 53463 53980 +517
==========================================
+ Hits 32836 33146 +310
- Misses 16448 16603 +155
- Partials 4179 4231 +52
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
reviewed
Feb 1, 2023
go/consensus/tendermint/apps/keymanager/state/interop/interop.go
Outdated
Show resolved
Hide resolved
peternose
force-pushed
the
peternose/feature/ephemeral-keys-forward-secrecy
branch
4 times, most recently
from
f5cf32e
to
13f602f
Compare
kostko
reviewed
Feb 13, 2023
peternose
force-pushed
the
peternose/feature/ephemeral-keys-forward-secrecy
branch
2 times, most recently
from
cdcbd4b
to
44fcba1
Compare
kostko
reviewed
Feb 14, 2023
kostko
reviewed
Feb 14, 2023
Renamed MasterSecret so that it can be used for ephemeral secrets also. Refactored kdf so that keys can be derived from an arbitrary secret.
Moved init_kdf function to methods.rs. Refactored key manager methods so that context is the first parameter.
The RPC client retries RPC calls if they fail. This was also true if the peer list was empty, introducing additional latencies.
peternose
force-pushed
the
peternose/feature/ephemeral-keys-forward-secrecy
branch
from
44fcba1
to
b3254c1
Compare
kostko
approved these changes
Feb 16, 2023
peternose
force-pushed
the
peternose/feature/ephemeral-keys-forward-secrecy
branch
2 times, most recently
from
e612b99
to
dec4a75
Compare
Deriving ephemeral keys from the key manager's master secret did not guarantee forward secrecy. In order to fulfill this requirement, we needed ephemeral secrets that are randomly generated on every epoch and distributed securely amongst enclave executors.
peternose
force-pushed
the
peternose/feature/ephemeral-keys-forward-secrecy
branch
from
dec4a75
to
badd3c9
Compare
peternose
deleted the
peternose/feature/ephemeral-keys-forward-secrecy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
See ADR21 for details. Changes:
TODO: Discuss/solve upgrade procedure.
Tests
No need to introduce a new feature as the new key manager node will silently ignore errors when sending new RPC requests to an outdated enclave.