Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/worker/compute: Do not drop valid proposals #5161

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

kostko
Copy link
Member

@kostko kostko commented Feb 2, 2023

Previously valid proposals could be dropped instead of being forwarded via the P2P gossip when the local node's consensus view was slightly behind even though the proposal was valid. With smaller committees and certain topologies this could result in some nodes not getting the proposals.

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Merging #5161 (e8408f9) into master (516f30a) will increase coverage by 0.10%.
The diff coverage is 74.79%.

❗ Current head e8408f9 differs from pull request most recent head 1aaa8d7. Consider uploading reports for the commit 1aaa8d7 to get more accurate results

@@            Coverage Diff             @@
##           master    #5161      +/-   ##
==========================================
+ Coverage   66.83%   66.94%   +0.10%     
==========================================
  Files         496      497       +1     
  Lines       53303    53300       -3     
==========================================
+ Hits        35626    35682      +56     
+ Misses      13339    13266      -73     
- Partials     4338     4352      +14     
Impacted Files Coverage Δ
go/worker/compute/executor/committee/state.go 100.00% <ø> (+12.90%) ⬆️
go/worker/compute/executor/committee/p2p.go 66.66% <50.00%> (-8.34%) ⬇️
...consensus/tendermint/apps/keymanager/keymanager.go 73.79% <68.75%> (+11.74%) ⬆️
go/keymanager/api/api.go 82.85% <75.00%> (+2.21%) ⬆️
go/worker/compute/executor/committee/proposals.go 81.25% <81.25%> (ø)
go/worker/compute/executor/committee/node.go 73.62% <88.23%> (+5.30%) ⬆️
go/consensus/tendermint/abci/state/state.go 61.53% <0.00%> (-7.70%) ⬇️
go/staking/api/api.go 57.53% <0.00%> (-6.03%) ⬇️
go/storage/mkvs/lookup.go 75.00% <0.00%> (-4.17%) ⬇️
go/consensus/tendermint/full/services.go 74.81% <0.00%> (-3.71%) ⬇️
... and 41 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kostko kostko force-pushed the kostko/fix/p2p-proposal-fwd branch 5 times, most recently from e1c834b to 3892609 Compare February 2, 2023 19:31
@kostko kostko marked this pull request as ready for review February 3, 2023 07:43
@kostko kostko requested a review from peternose February 3, 2023 07:48
@kostko kostko force-pushed the kostko/fix/p2p-proposal-fwd branch from 3892609 to 2fc2001 Compare February 3, 2023 10:52
Previously valid proposals could be dropped instead of being forwarded
via the P2P gossip when the local node's consensus view was slightly
behind even though the proposal was valid. With smaller committees and
certain topologies this could result in some nodes not getting the
proposals.
@kostko kostko force-pushed the kostko/fix/p2p-proposal-fwd branch from e8408f9 to 1aaa8d7 Compare February 3, 2023 13:50
@kostko kostko merged commit 58f17c6 into master Feb 3, 2023
@kostko kostko deleted the kostko/fix/p2p-proposal-fwd branch February 3, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c:bug Category: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants