Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keymanager: Add support for master secret generations #5198

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

peternose
Copy link
Contributor

Master secret rotation, 1st part:

  • Refactor key manager's init method to be able to support multiple generations of the master secret.

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #5198 (cf872c2) into master (cf5e508) will increase coverage by 0.13%.
The diff coverage is n/a.

❗ Current head cf872c2 differs from pull request most recent head c5a594a. Consider uploading reports for the commit c5a594a to get more accurate results

@@            Coverage Diff             @@
##           master    #5198      +/-   ##
==========================================
+ Coverage   61.47%   61.60%   +0.13%     
==========================================
  Files         512      512              
  Lines       54051    54055       +4     
==========================================
+ Hits        33227    33303      +76     
+ Misses      16611    16525      -86     
- Partials     4213     4227      +14     
Impacted Files Coverage Δ
go/roothash/api/sanity_check.go 60.00% <0.00%> (-8.00%) ⬇️
go/common/cbor/codec.go 78.37% <0.00%> (-5.41%) ⬇️
go/runtime/host/helpers.go 66.03% <0.00%> (-3.78%) ⬇️
go/runtime/host/protocol/connection.go 62.03% <0.00%> (-3.01%) ⬇️
go/consensus/tendermint/abci/mux.go 44.44% <0.00%> (-2.63%) ⬇️
go/consensus/tendermint/apps/roothash/messages.go 71.42% <0.00%> (-2.39%) ⬇️
go/oasis-node/cmd/node/node.go 51.40% <0.00%> (-2.19%) ⬇️
go/p2p/peermgmt/peermgr.go 84.87% <0.00%> (-1.96%) ⬇️
go/p2p/peermgmt/connector.go 98.16% <0.00%> (-1.84%) ⬇️
go/oasis-node/cmd/stake/delegations.go 78.99% <0.00%> (-1.69%) ⬇️
... and 30 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternose peternose marked this pull request as ready for review February 24, 2023 13:06
keymanager/src/api/requests.rs Show resolved Hide resolved
keymanager/src/api/requests.rs Show resolved Hide resolved
keymanager/src/crypto/kdf.rs Outdated Show resolved Hide resolved
keymanager/src/crypto/kdf.rs Show resolved Hide resolved
keymanager/src/crypto/kdf.rs Outdated Show resolved Hide resolved
keymanager/src/crypto/kdf.rs Outdated Show resolved Hide resolved
keymanager/src/runtime/methods.rs Show resolved Hide resolved
keymanager/src/runtime/methods.rs Show resolved Hide resolved
@peternose peternose force-pushed the peternose/internal/km_init_generations branch from 28db5a8 to cf872c2 Compare February 25, 2023 06:37
Refactor key manager's init method to be able to support multiple
generations of the master secret.
@peternose peternose force-pushed the peternose/internal/km_init_generations branch from cf872c2 to c5a594a Compare February 27, 2023 21:37
@peternose peternose merged commit b82b8b3 into master Feb 27, 2023
@peternose peternose deleted the peternose/internal/km_init_generations branch February 27, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants