Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/keymanager/api: Add signed encrypted master secret #5199

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

peternose
Copy link
Contributor

Master secret rotation, 2nd part:

  • Add signed encrypted master secret.

@peternose peternose force-pushed the peternose/internal/sig_enc_master_secret branch from f0a14c9 to f977ca9 Compare February 24, 2023 12:44
@peternose peternose marked this pull request as ready for review February 24, 2023 13:05
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #5199 (a59439d) into master (cf5e508) will decrease coverage by 0.22%.
The diff coverage is 40.94%.

@@            Coverage Diff             @@
##           master    #5199      +/-   ##
==========================================
- Coverage   61.47%   61.25%   -0.22%     
==========================================
  Files         512      512              
  Lines       54051    54230     +179     
==========================================
- Hits        33227    33218       -9     
- Misses      16611    16786     +175     
- Partials     4213     4226      +13     
Impacted Files Coverage Δ
go/registry/api/api.go 52.78% <0.00%> (-0.16%) ⬇️
go/worker/compute/executor/committee/node.go 58.90% <22.22%> (-0.27%) ⬇️
go/runtime/host/multi/multi.go 45.52% <24.80%> (-21.38%) ⬇️
go/worker/common/committee/node.go 57.36% <40.00%> (-0.58%) ⬇️
go/runtime/host/sandbox/sandbox.go 56.65% <50.00%> (-0.20%) ⬇️
go/worker/keymanager/worker.go 63.36% <50.00%> (+1.98%) ⬆️
go/runtime/registry/host.go 49.90% <66.66%> (+0.20%) ⬆️
go/keymanager/api/secret.go 76.31% <78.57%> (+18.42%) ⬆️
...nsensus/tendermint/apps/keymanager/transactions.go 42.53% <100.00%> (ø)
go/registry/api/runtime.go 51.42% <100.00%> (+1.01%) ⬆️
... and 33 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@peternose peternose force-pushed the peternose/internal/sig_enc_master_secret branch from f977ca9 to a59439d Compare February 27, 2023 23:57
@peternose peternose merged commit b434041 into master Feb 28, 2023
@peternose peternose deleted the peternose/internal/sig_enc_master_secret branch February 28, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants