keymanager/src/runtime: Remove legacy version of init request #5205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
force-pushed
the
peternose/internal/km_init_status_fix
branch
from
d01e911
to
973840f
Compare
This was referenced Dec 5, 2023
peternose
force-pushed
the
peternose/internal/km_init_status_fix
branch
from
973840f
to
2455a4c
Compare
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
peternose
force-pushed
the
peternose/internal/km_init_status_fix
branch
from
2455a4c
to
7247712
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5205 +/- ##
==========================================
+ Coverage 66.92% 66.98% +0.06%
==========================================
Files 534 534
Lines 56588 56568 -20
==========================================
+ Hits 37870 37891 +21
+ Misses 14286 14266 -20
+ Partials 4432 4411 -21 ☔ View full report in Codecov by Sentry. |
peternose
force-pushed
the
peternose/internal/km_init_status_fix
branch
from
7247712
to
4a113bb
Compare
peternose
force-pushed
the
peternose/internal/km_init_status_fix
branch
from
4a113bb
to
7cfb7d3
Compare
kostko
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be updated and merged after Oasis Core 23.0.x is released and all key managers support master secret rotation.
See also #5204.