go/worker/keymanager: Refactor the main loop in the key manager worker #5212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternose
force-pushed
the
peternose/internal/refactor_km_worker
branch
from
19950c9
to
24d21e7
Compare
Codecov Report
@@ Coverage Diff @@
## master #5212 +/- ##
==========================================
+ Coverage 61.30% 61.38% +0.07%
==========================================
Files 512 512
Lines 54246 54243 -3
==========================================
+ Hits 33256 33295 +39
+ Misses 16754 16721 -33
+ Partials 4236 4227 -9
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
approved these changes
Mar 6, 2023
go/worker/keymanager/worker.go
Outdated
| } | ||
|
|
||
| func (w *Worker) handleNewEphemeralSecret(secret *api.SignedEncryptedEphemeralSecret, epoch beacon.EpochTime) { | ||
| if secret.Secret.ID != w.runtimeID { |
There was a problem hiding this comment.
Direct comparison here, .Equal above? Should it be made consistent?
Simplify the main for loop and organize the code by adding additional functions.
peternose
force-pushed
the
peternose/internal/refactor_km_worker
branch
from
24d21e7
to
01e9f22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the main for loop and organize the code by adding additional functions.