go/worker/keymanager: Optimize enclave initialization #5218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5218 +/- ##
==========================================
+ Coverage 61.51% 61.62% +0.11%
==========================================
Files 512 512
Lines 54243 54281 +38
==========================================
+ Hits 33365 33449 +84
+ Misses 16640 16598 -42
+ Partials 4238 4234 -4
... and 29 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
peternose
force-pushed
the
peternose/feature/optimize-km-status-update
branch
2 times, most recently
from
aba6ccf
to
4ce1ee0
Compare
peternose
requested review from
kostko,
peterjgilbert,
pro-wh and
ptrus
as code owners
kostko
approved these changes
Mar 13, 2023
peternose
force-pushed
the
peternose/feature/optimize-km-status-update
branch
2 times, most recently
from
a9f02fc
to
c3c4ec6
Compare
Enclave initialization was moved into its own goroutine to avoid blocking the main loop of the key manager worker. Once initialization is completed, the resulting state of the enclave is compared to the latest key manager status. If the latter has changed, initialization is performed again. This will be useful when we deploy master secret rotation since new secrets may be generated while old secrets are being replicated which can result in an outdated state once initialization finishes.
peternose
force-pushed
the
peternose/feature/optimize-km-status-update
branch
from
c3c4ec6
to
a3909bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enclave initialization was moved into its own goroutine to avoid blocking the main loop of the key manager worker. Once initialization is completed, the resulting state of the enclave is compared to the latest key manager status. If the latter has changed, initialization is performed again.
This will be useful when we deploy master secret rotation since new secrets may be generated while old secrets are being replicated which can result in an outdated state once initialization finishes.